[GitHub] carbondata pull request #1757: [CARBONDATA-1977][PARTITION] Fix aggregation ...

[jackylk <gi...@git.apache.org>]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1757#discussion_r159605621
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/events/LoadEvents.java ---
    @@ -0,0 +1,152 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.processing.loading.events;
    +
    +import java.util.Map;
    +
    +import org.apache.carbondata.core.metadata.CarbonTableIdentifier;
    +import org.apache.carbondata.events.Event;
    +import org.apache.carbondata.processing.loading.model.CarbonLoadModel;
    +
    +public class LoadEvents {
    +  /**
    +   * Class for handling operations before start of a load process.
    +   * Example usage: For validation purpose
    +   */
    +  public static class LoadTablePreExecutionEvent extends Event {
    +    private CarbonTableIdentifier carbonTableIdentifier;
    +    private CarbonLoadModel carbonLoadModel;
    +    private String factPath;
    +    private boolean isDataFrameDefined;
    +    private Map<String, String> optionsFinal;
    +    // userProvidedOptions are needed if we need only the load options given by user
    +    private Map<String, String> userProvidedOptions;
    +    private boolean isOverWriteTable;
    +
    +    public LoadTablePreExecutionEvent(CarbonTableIdentifier carbonTableIdentifier,
    +        CarbonLoadModel carbonLoadModel, String factPath, boolean isDataFrameDefined,
    +        Map<String, String> optionsFinal, Map<String, String> userProvidedOptions,
    +        boolean isOverWriteTable) {
    +      this.carbonTableIdentifier = carbonTableIdentifier;
    +      this.carbonLoadModel = carbonLoadModel;
    +      this.factPath = factPath;
    +      this.isDataFrameDefined = isDataFrameDefined;
    +      this.optionsFinal = optionsFinal;
    +      this.userProvidedOptions = userProvidedOptions;
    +      this.isOverWriteTable = isOverWriteTable;
    +    }
    +
    +    public CarbonTableIdentifier getCarbonTableIdentifier() {
    +      return carbonTableIdentifier;
    +    }
    +
    +    public CarbonLoadModel getCarbonLoadModel() {
    +      return carbonLoadModel;
    +    }
    +
    +    public String getFactPath() {
    +      return factPath;
    +    }
    +
    +    public boolean isDataFrameDefined() {
    +      return isDataFrameDefined;
    +    }
    +
    +    public Map<String, String> getOptionsFinal() {
    +      return optionsFinal;
    +    }
    +
    +    public Map<String, String> getUserProvidedOptions() {
    +      return userProvidedOptions;
    +    }
    +
    +    public boolean isOverWriteTable() {
    +      return isOverWriteTable;
    +    }
    +  }
    +
    +  /**
    +   * Class for handling operations after data load completion and before final
    +   * commit of load operation. Example usage: For loading pre-aggregate tables
    --- End diff --
    
    I remember, we will move all command execution out of event listener, right? 
    Otherwise, metadata and data process may be wrong


---