You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/03/15 14:55:28 UTC
[Bug 6376] New: win32: consider negative pids under windows in
spamds waitpid
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Summary: win32: consider negative pids under windows in spamds
waitpid
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P5
Component: spamc/spamd
AssignedTo: dev@spamassassin.apache.org
ReportedBy: lemke@jam-software.com
As already mentioned in Bug 6356 windows does create negative pids for its
children. In conjunction with spamd this causes the children to be stated as
killed, but not be able to exit properly.
waitpid(-1, WNOHANG)) > 0) #unix
waitpid(-1, WNOHANG)) < -1) #win32
I just added another while loop for this, there may be a much more professional
solution, but I'll leave this to our perl gurus ;)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from Mark Martinec <Ma...@ijs.si> 2011-05-08 21:20:02 UTC ---
3.3:
Bug 6376: win32: consider negative pids under windows in spamds waitpid
Sending spamd/spamd.raw
Committed revision 1100818.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] win32: consider negative pids under windows in spamds
waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2010-06-01 09:54:28 EDT ---
Created an attachment (id=4764)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4764)
proposed replacement patch - more general, based on perl docs
Turns out that perl docs on waitpid only talks about return values -1 and 0,
and does not disallow negative pids. So I think the attached patch offers
a leaner and more general solution.
trunk:
Bug 6376: win32: consider negative pids under windows in spamd's waitpid
Sending spamd/spamd.raw
Committed revision 950076.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2010-06-08 08:20:59 EDT ---
(In reply to comment #2)
> The question how the CLA for the patch affects things is my only question
Daniel wrote yesterday (2010-06-07):
> I submitted the CLA, according ASF secretary it should now be filed in.
so this is done now - thanks Daniel!
Btw, does the CLA status in Bugzilla change automagically,
or is there something we need to do explicitly?
> so I vote +1 assuming that's OK.
Can this be extended to my modified patch?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] win32: consider negative pids under windows in spamds
waitpid
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Target Milestone|Undefined |3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
--- Comment #4 from Kevin A. McGrail <km...@pccc.com> 2010-06-01 09:56:42 EDT ---
(In reply to comment #3)
> Created an attachment (id=4764)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4764) [details]
> proposed replacement patch - more general, based on perl docs
>
> Turns out that perl docs on waitpid only talks about return values -1 and 0,
> and does not disallow negative pids. So I think the attached patch offers
> a leaner and more general solution.
>
> trunk:
> Bug 6376: win32: consider negative pids under windows in spamd's waitpid
> Sending spamd/spamd.raw
> Committed revision 950076.
+1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|win32: consider negative |[review] win32: consider
|pids under windows in |negative pids under windows
|spamds waitpid |in spamds waitpid
Status Whiteboard| |needs 2 votes
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hege@hege.li
Status Whiteboard|needs 1 vote |ready to commit for 3.3.2
--- Comment #7 from Henrik Krohns <he...@hege.li> 2011-05-08 13:22:10 UTC ---
+1 for Mark's patch
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] win32: consider negative pids under windows in spamds
waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #2 from Kevin A. McGrail <km...@pccc.com> 2010-05-31 18:21:43 EDT ---
As with 6377, I have not tested the patch but there are people who say it works
on windows and the logic that it affects only windows-users seems sound.
The question how the CLA for the patch affects things is my only question so I
vote +1 assuming that's OK.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] [review] win32: consider negative pids under windows in
spamds waitpid
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jm@jmason.org
--- Comment #6 from Justin Mason <jm...@jmason.org> 2010-06-08 08:57:07 EDT ---
(In reply to comment #5)
> Btw, does the CLA status in Bugzilla change automagically,
> or is there something we need to do explicitly?
we do it explicitly....
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6376] win32: consider negative pids under windows in spamds
waitpid
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6376
--- Comment #1 from Daniel <le...@jam-software.com> 2010-03-15 13:56:52 UTC ---
Created an attachment (id=4712)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4712)
consider negative pid in waitpid under win32
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.