You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ro4i7 (via GitHub)" <gi...@apache.org> on 2023/03/14 19:07:40 UTC

[GitHub] [apisix] ro4i7 opened a new pull request, #9067: Update deployment-modes.md

ro4i7 opened a new pull request, #9067:
URL: https://github.com/apache/apisix/pull/9067

   Added the new link to the old stand-alone doc #9058
   
   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes # (issue)
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] kayx23 commented on a diff in pull request #9067: docs: Update deployment-modes.md

Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on code in PR #9067:
URL: https://github.com/apache/apisix/pull/9067#discussion_r1338069708


##########
docs/en/latest/deployment-modes.md:
##########
@@ -161,6 +161,8 @@ deployment:
 
 Turning on the APISIX node in Stand-alone mode will no longer use the default etcd as the configuration center.
 
+For the old version of the standalone mode deployment guide, see the [stand-alone mode documentation](https://apisix.apache.org/docs/apisix/deployment-modes/#standalone).

Review Comment:
   How is this the "old version"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: Update deployment-modes.md [apisix]

Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9067:
URL: https://github.com/apache/apisix/pull/9067#issuecomment-1753973440

   The OG issue by @monkeyDluffy6017 states to add a new link in the old stand-alone doc to point to the new doc. This PR adds a link to itself and proposes changes for the master branch (which is the wrong branch). So it's not exactly what was asked.
   
   @monkeyDluffy6017 - please check to see if the original req still persists. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9067: docs: Update deployment-modes.md

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9067:
URL: https://github.com/apache/apisix/pull/9067#issuecomment-1469131680

   It's the old stand-alone doc found first, can we add a new link to the old doc?
   ![image](https://user-images.githubusercontent.com/9354193/225180789-d7f80c74-45da-4866-bae7-bf1cfe2ff4e8.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: Update deployment-modes.md [apisix]

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9067:
URL: https://github.com/apache/apisix/pull/9067#issuecomment-1754257989

   We can close this pr and the related issue now, as we were able to find the right page during the search
   ![image](https://github.com/apache/apisix/assets/9354193/5cfdaec0-068f-4834-b816-6e7342f921f8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] ro4i7 commented on pull request #9067: [Doc] Update deployment-modes.md

Posted by "ro4i7 (via GitHub)" <gi...@apache.org>.
ro4i7 commented on PR #9067:
URL: https://github.com/apache/apisix/pull/9067#issuecomment-1468696143

   @monkeyDluffy6017 @spacewander please check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] ro4i7 commented on pull request #9067: docs: Update deployment-modes.md

Posted by "ro4i7 (via GitHub)" <gi...@apache.org>.
ro4i7 commented on PR #9067:
URL: https://github.com/apache/apisix/pull/9067#issuecomment-1476059571

   > It's the old stand-alone doc found first, can we add a new link in the old doc? ![image](https://user-images.githubusercontent.com/9354193/225180789-d7f80c74-45da-4866-bae7-bf1cfe2ff4e8.png)
   
   @monkeyDluffy6017 yeah, Got it. I have updated it please check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: Update deployment-modes.md [apisix]

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 closed pull request #9067: docs: Update deployment-modes.md
URL: https://github.com/apache/apisix/pull/9067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org