You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/21 04:13:31 UTC
[GitHub] [spark] sarutak opened a new pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
sarutak opened a new pull request #31270:
URL: https://github.com/apache/spark/pull/31270
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR reverts SPARK-33888 (#30902) .
That PR has the two serious problems.
1. Regression which affects PostgresDialect causing `PostgreSQLIntegrationSuite` to fail.
2. That PR changes the JDBC-Catalyst type mapping. `sql.Types.TIME` is mapped to `sql.types.IntegerType` so we'll get millisecond value. But the start time point is different between `MsSqlServer` and other RDBMSs. For `MsSqlServer`, it starts from `1900-01-01 00:00:00` while `1970-01-01 00:00:00` for other RDBMS.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix the serious issues.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
This is just reverting a previous change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764332304
@cloud-fan O.K, I'll close this PR and open another PR to fix the wrong assertion. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764290200
What do you mean by "start time point"? The TIME type has no date part and should return seconds(with certain precision) of the hour:minute:second fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764316844
@cloud-fan
Or, do you think the `assert(row.getAs[Timestamp](5).equals(Timestamp.valueOf("1900-01-01 13:31:24.0")))` is wrong because it contains date part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764327247
@sarutak can you take a look at https://github.com/apache/spark/pull/30902/files#r561601546 ? I think the test is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764373360
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38890/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764317607
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38890/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764403534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38890/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764403534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38890/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #31270:
URL: https://github.com/apache/spark/pull/31270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764403534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38890/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764303916
@cloud-fan
> What do you mean by "start time point"? The TIME type has no date part and should return seconds(with certain precision) of the hour:minute:second fields.
Yes it has no date part. So in MsSqlServer, the date part is assumed `1900-01-01 00:00:00` while other RDBMS assumes it as `1970-01-01 00:00:00`.
https://docs.microsoft.com/ja-jp/sql/t-sql/data-types/time-transact-sql?view=sql-server-ver15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764317607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #31270:
URL: https://github.com/apache/spark/pull/31270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764403534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38890/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764290200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31270:
URL: https://github.com/apache/spark/pull/31270#issuecomment-764303916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org