You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/09 20:53:39 UTC

[GitHub] [logging-log4j2] vy commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

vy commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008421459


   Fantastic work @atulpendse! Thanks so much!
   
   Mind adding `SyslogAppender` tests and a `changes.xml` entry, please?
   
   I am also not sure if a `timestampPrecision` argument of type `String` is the right way to go. Thinking out loudly:
   - Why don't we simply make the instant formatting pattern configurable?
   - Doesn't the spec enforce a certain precision?
   - If not, why don't we simply (automatically?) pick the most precise representation possible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org