You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/29 05:12:42 UTC
[GitHub] [mynewt-core] vikrant-proxy opened a new pull request #2649: sys/console/minimal: Fix RTT console compiler error for minimal console
vikrant-proxy opened a new pull request #2649:
URL: https://github.com/apache/mynewt-core/pull/2649
Compile `console_out` for UART console only. RTT console has it's own implementation of `console_out` which conflicts if RTT_CONSOLE is used with console/minimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vikrant-proxy commented on pull request #2649: sys/console/minimal: Fix RTT console compiler error for minimal console
Posted by GitBox <gi...@apache.org>.
vikrant-proxy commented on pull request #2649:
URL: https://github.com/apache/mynewt-core/pull/2649#issuecomment-894669113
Thanks @kasjer ! Can you take a look at https://github.com/apache/mynewt-core/pull/2656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2649: sys/console/minimal: Fix RTT console compiler error for minimal console
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2649:
URL: https://github.com/apache/mynewt-core/pull/2649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on pull request #2649: sys/console/minimal: Fix RTT console compiler error for minimal console
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2649:
URL: https://github.com/apache/mynewt-core/pull/2649#issuecomment-894658567
This is not correct way to do this.
rtt console should have function name change from **console_out** to **console_out_nolock**.
This was done for all other cases 2 years back and it looks like rtt minimal console was left out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org