[GitHub] spark pull request #13930: [SPARK-16228][SQL] HiveSessionCatalog should retu...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13930#discussion_r68682430
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
    @@ -174,6 +175,18 @@ private[sql] class HiveSessionCatalog(
       // xpath_double, xpath_float, xpath_int, xpath_long, xpath_number,
       // xpath_short, and xpath_string.
       override def lookupFunction(name: FunctionIdentifier, children: Seq[Expression]): Expression = {
    +    try {
    +      subLookupFunction(name, children)
    +    } catch {
    +      case _: Exception =>
    +        // SPARK-16228 ExternalCatalog may recognize `double`-type only.
    +        val newChildren = children.map(x =>
    +          if (x.dataType.isInstanceOf[DecimalType]) Cast(x, DoubleType) else x)
    +        subLookupFunction(name, newChildren)
    +    }
    +  }
    +
    +  private def subLookupFunction(name: FunctionIdentifier, children: Seq[Expression]): Expression = {
    --- End diff --
    
    `subLookupFunction` seems not a good name. Any suitable convention in Spark?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org