You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 12:05:30 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #20712: Fix MyPy issues in providers imap

kaxil commented on a change in pull request #20712:
URL: https://github.com/apache/airflow/pull/20712#discussion_r779501008



##########
File path: airflow/providers/imap/hooks/imap.py
##########
@@ -71,7 +71,11 @@ def get_conn(self) -> 'ImapHook':
         """
         if not self.mail_client:
             conn = self.get_connection(self.imap_conn_id)
-            self.mail_client = imaplib.IMAP4_SSL(conn.host, conn.port or imaplib.IMAP4_SSL_PORT)
+            self.mail_client = imaplib.IMAP4_SSL(
+                conn.host, conn.port or imaplib.IMAP4_SSL_PORT  # type:ignore
+            )
+            # imaplib.IMAP4_SSL() aspects port in the argument and port here is conn.port or

Review comment:
       ```suggestion
               # imaplib.IMAP4_SSL() expects port in the argument and port here is conn.port or
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org