You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/27 17:53:45 UTC

[GitHub] [solr] markrmiller opened a new pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

markrmiller opened a new pull request #311:
URL: https://github.com/apache/solr/pull/311


   https://issues.apache.org/jira/browse/SOLR-15646
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller commented on pull request #311:
URL: https://github.com/apache/solr/pull/311#issuecomment-932675308


   A quick look at why, unrelated to your efforts here, I'm a bit pre-frustrated with debating this issue and being told it's already been solved for me.
   
   I run a sample of tests with Async Profiler, hoping to dig into and observe some behavior and results.
   
   I jump to the test at the top of the list. You can see on the left the impact of some key generation that occurs for every test that doesn't even touch that functionality. To the right, all those columns labeled with init - are also key generation. 
   ![image](https://user-images.githubusercontent.com/448788/135702432-50b34797-1306-4e7a-8983-1707a083035b.jpeg)
   
   Move to the next test. I still can find much valuable to observe. Key gen key gen key gen, init labels are again also keygen.
   ![image](https://user-images.githubusercontent.com/448788/135702435-ff2ead47-9388-40f2-a181-0a73c8e0a530.jpeg)
   
   Next test, same thing.
   ![image](https://user-images.githubusercontent.com/448788/135702438-cd78ff42-a4c4-4463-98ca-e4f816b66107.jpeg)
   
   And the next.
   ![image](https://user-images.githubusercontent.com/448788/135702442-d34c1cce-a7b0-4632-b74a-c2de116c502d.jpeg)
   
   We skip a test, the package test doesn't seem to suffer, the following test, I'm again swamped by keygen.
   ![image](https://user-images.githubusercontent.com/448788/135702447-289218f2-c70e-4a6f-8cfe-e1ee3db36557.jpeg)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller closed pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller closed pull request #311:
URL: https://github.com/apache/solr/pull/311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller commented on pull request #311:
URL: https://github.com/apache/solr/pull/311#issuecomment-958967962






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller commented on pull request #311:
URL: https://github.com/apache/solr/pull/311#issuecomment-958967962


   This can be worked around using the system property that disables all secure random usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller closed pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller closed pull request #311:
URL: https://github.com/apache/solr/pull/311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller edited a comment on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller edited a comment on pull request #311:
URL: https://github.com/apache/solr/pull/311#issuecomment-932675308


   A quick look at why, unrelated to your efforts here, I'm a bit pre-frustrated with debating this issue and being told it's already been solved for me.
   
   I run a sample of tests with Async Profiler, hoping to dig into and observe some behavior and results.
   
   I jump to the test at the top of the list. You can see on the left the impact of some key generation that occurs for every test that doesn't even touch that functionality. To the right, all those columns labeled with init - are also key generation. 
   ![image](https://user-images.githubusercontent.com/448788/135702432-50b34797-1306-4e7a-8983-1707a083035b.jpeg)
   
   Move to the next test. I still cant find much valuable to observe. Key gen key gen key gen, init labels are again also keygen.
   ![image](https://user-images.githubusercontent.com/448788/135702435-ff2ead47-9388-40f2-a181-0a73c8e0a530.jpeg)
   
   Next test, same thing.
   ![image](https://user-images.githubusercontent.com/448788/135702438-cd78ff42-a4c4-4463-98ca-e4f816b66107.jpeg)
   
   And the next.
   ![image](https://user-images.githubusercontent.com/448788/135702442-d34c1cce-a7b0-4632-b74a-c2de116c502d.jpeg)
   
   We skip a test, the package test doesn't seem to suffer, the following test, I'm again swamped by keygen.
   ![image](https://user-images.githubusercontent.com/448788/135702447-289218f2-c70e-4a6f-8cfe-e1ee3db36557.jpeg)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller commented on pull request #311:
URL: https://github.com/apache/solr/pull/311#issuecomment-958967962


   This can be worked around using the system property that disables all secure random usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] markrmiller closed pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

Posted by GitBox <gi...@apache.org>.
markrmiller closed pull request #311:
URL: https://github.com/apache/solr/pull/311






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org