You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by yu...@apache.org on 2023/02/27 04:47:11 UTC
[rocketmq] branch develop updated: Optimize getQueueIdByBroker naming ambiguity
This is an automated email from the ASF dual-hosted git repository.
yukon pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 2f93cbe05 Optimize getQueueIdByBroker naming ambiguity
2f93cbe05 is described below
commit 2f93cbe051eb82834ee1ecba981c820a966190f3
Author: loboxu <lo...@tencent.com>
AuthorDate: Sat Feb 18 15:50:28 2023 +0800
Optimize getQueueIdByBroker naming ambiguity
---
.../java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java | 2 +-
.../main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java
index b7c4418d9..a5f840500 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java
@@ -89,7 +89,7 @@ public class TopicPublishInfo {
return this.messageQueueList.get(pos);
}
- public int getQueueIdByBroker(final String brokerName) {
+ public int getWriteQueueIdByBroker(final String brokerName) {
for (int i = 0; i < topicRouteData.getQueueDatas().size(); i++) {
final QueueData queueData = this.topicRouteData.getQueueDatas().get(i);
if (queueData.getBrokerName().equals(brokerName)) {
diff --git a/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java b/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java
index 2b5cd9149..bd0818688 100644
--- a/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java
+++ b/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java
@@ -67,7 +67,7 @@ public class MQFaultStrategy {
}
final String notBestBroker = latencyFaultTolerance.pickOneAtLeast();
- int writeQueueNums = tpInfo.getQueueIdByBroker(notBestBroker);
+ int writeQueueNums = tpInfo.getWriteQueueIdByBroker(notBestBroker);
if (writeQueueNums > 0) {
final MessageQueue mq = tpInfo.selectOneMessageQueue();
if (notBestBroker != null) {