You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2024/09/26 23:44:42 UTC

[PR] Refactor the read and write functions in Unix and SSL NetVC [trafficserver]

maskit opened a new pull request, #11794:
URL: https://github.com/apache/trafficserver/pull/11794

   There are redundant wrapper functions in UnixNetVC and the design is inconstant between read and write, and also between UnixNetVC and SSLNetVC.
   
   This PR is a first step for further refactoring/abstraction. It removes those redundant functions and aligns the design. I also removed a few parameters that don't need to be passed around. There should be no change in the flow.
   
   With this change, we should be able to move the TLS related code into SSLNetVC from UnixNetVC like `load_buffer_and_write`.
   
   Before
   
   UnixNetVConnection
   ```
   UnixNetVConnection::net_read_io -> ::read_from_net
   UnixNetVConnection::net_write_io -> ::write_to_net -> ::write_to_net_io -> UnixNetVConnection::load_buffer_and_write
   UnixNetVConnection::netActivity -> ::net_activity
   ```
   SSLNetVConnection
   ```
   SSLNetVConnection::net_read_io
   UnixNetVConnection::net_write_io -> ::write_to_net -> ::write_to_net_io -> SSLNetVConnection::load_buffer_and_write
   ```
   
   After
   
   UnixNetVConnection
   ```
   UnixNetVConnection::net_read_io
   UnixNetVConnection::net_write_io -> UnixNetVConnection::load_buffer_and_write
   UnixNetVConnection::netActivity
   ```
   
   SSLNetVConnection
   ```
   SSLNetVConnection::net_read_io
   UnixNetVConnection::net_write_io -> SSLNetVConnection::load_buffer_and_write
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor the read and write functions in Unix and SSL NetVC [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11794:
URL: https://github.com/apache/trafficserver/pull/11794#issuecomment-2378211305

   stale_response failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor the read and write functions in Unix and SSL NetVC [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11794:
URL: https://github.com/apache/trafficserver/pull/11794#issuecomment-2378420678

   Jenkins failed to fetch git repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor the read and write functions in Unix and SSL NetVC [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit merged PR #11794:
URL: https://github.com/apache/trafficserver/pull/11794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor the read and write functions in Unix and SSL NetVC [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11794:
URL: https://github.com/apache/trafficserver/pull/11794#issuecomment-2378211409

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor the read and write functions in Unix and SSL NetVC [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11794:
URL: https://github.com/apache/trafficserver/pull/11794#issuecomment-2378420769

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org