[GitHub] [ignite] Vladsz83 commented on a change in pull request #7358: IGNITE-12614 : Disallow silent deactivation of cluster to prevent in-mem data loss.

[GitBox <gi...@apache.org>]

Vladsz83 commented on a change in pull request #7358: IGNITE-12614 : Disallow silent deactivation of cluster to prevent in-mem data loss.
URL: https://github.com/apache/ignite/pull/7358#discussion_r375358728
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/commandline/ClusterStateChangeCommand.java
 ##########
 @@ -42,6 +63,26 @@
     /** Cluster name. */
     private String clusterName;
 
+    /** Force cluster deactivation even it might have in-mem caches. */
+    private boolean force;
+
+    /**
+     * Checks if it is resonable to deactivate cluster.
+     *
+     * @param taskLauncher Computation task launcher. The task has no params, just needs to be launched for its result.
+     * @return Empty (not-null) message if cluster is ready. Or warning text telling why deactivation is not advised.
+     */
+    @NotNull public static String isClusterReadyForDeactivation(
 
 Review comment:
   Not actual. Code changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services