[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

[uce <gi...@git.apache.org>]

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3366#discussion_r102205223
  
    --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
    @@ -81,6 +78,51 @@ angular.module('flinkApp')
         JobsService.stopJob($stateParams.jobid).then (data) ->
           {}
     
    +  loadJob = ()->
    +    JobsService.loadJob($stateParams.jobid).then (data) ->
    +      $scope.job = data
    +      $scope.vertices = data.vertices
    +      $scope.plan = data.plan
    +      MetricsService.setupMetrics($stateParams.jobid, data.vertices)
    +
    +  getWatermarks = (nodes)->
    +    deferred = $q.defer()
    +    watermarks = {}
    +    jid = $scope.job.jid
    +    angular.forEach nodes, (node, index) =>
    +      metricIds = []
    +      for num in [0..node.parallelism - 1]
    +        metricIds.push(num + ".currentLowWatermark")
    +      MetricsService.getMetrics(jid, node.id, metricIds).then (data) ->
    +        values = []
    +        for key, value of data.values
    +          values.push(id: key.replace('.currentLowWatermark', ''), value: value)
    +        watermarks[node.id] = values
    +        if index >= $scope.plan.nodes.length - 1
    +          deferred.resolve(watermarks)
    +    deferred.promise
    +
    +  getLowWatermarks = (watermarks)->
    --- End diff --
    
    Can we add a high level comment about what happens here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---