[GitHub] [echarts] Ovilia commented on a diff in pull request #17217: fix: fix the error caused by setting markArea x/y

[GitBox <gi...@apache.org>]

Ovilia commented on code in PR #17217:
URL: https://github.com/apache/echarts/pull/17217#discussion_r978246509


##########
src/component/marker/markerHelper.ts:
##########
@@ -147,6 +147,9 @@ export function dataTransform(
             item.coord = coord;
         }
     }
+    if (item.coord == null) {
+        item.coord = [];

Review Comment:
   I'm not sure but returning an array with 0 element doesn't seem to be *valid* by logic for the `coord`. What do you think if it returns `[null, null]`? Can you help test if it works?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org