You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/02 11:06:54 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #2791: stm32f7/stm32_qspi.c: Fix warning of format strings
no1wudi opened a new pull request #2791:
URL: https://github.com/apache/incubator-nuttx/pull/2791
## Summary
See title
## Impact
None
## Testing
Tested on stm32f746g-disco
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2791: stm32f7/stm32_qspi.c: Fix warning of format strings
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2791:
URL: https://github.com/apache/incubator-nuttx/pull/2791#discussion_r568618152
##########
File path: arch/arm/src/stm32f7/stm32_qspi.c
##########
@@ -1939,7 +1939,7 @@ static void qspi_setmode(struct qspi_dev_s *dev, enum qspi_mode_e mode)
}
qspi_putreg(priv, regval, STM32_QUADSPI_DCR_OFFSET);
- spiinfo("DCR=%08x\n", regval);
+ spiinfo("DCR=%08lx\n", regval);
Review comment:
BTW, shouldn't this be `spiinfo("DCR=%08" PRIx32 "\n", regval);`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2791: stm32f7/stm32_qspi.c: Fix warning of format strings
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2791:
URL: https://github.com/apache/incubator-nuttx/pull/2791#discussion_r568618152
##########
File path: arch/arm/src/stm32f7/stm32_qspi.c
##########
@@ -1939,7 +1939,7 @@ static void qspi_setmode(struct qspi_dev_s *dev, enum qspi_mode_e mode)
}
qspi_putreg(priv, regval, STM32_QUADSPI_DCR_OFFSET);
- spiinfo("DCR=%08x\n", regval);
+ spiinfo("DCR=%08lx\n", regval);
Review comment:
BTW, shouldn't this be `spiinfo("DCR=%08" PRIx32" \n", regval);`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2791: stm32f7/stm32_qspi.c: Fix warning of format strings
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2791:
URL: https://github.com/apache/incubator-nuttx/pull/2791#discussion_r568618152
##########
File path: arch/arm/src/stm32f7/stm32_qspi.c
##########
@@ -1939,7 +1939,7 @@ static void qspi_setmode(struct qspi_dev_s *dev, enum qspi_mode_e mode)
}
qspi_putreg(priv, regval, STM32_QUADSPI_DCR_OFFSET);
- spiinfo("DCR=%08x\n", regval);
+ spiinfo("DCR=%08lx\n", regval);
Review comment:
BTW, shouldn't this be `spiinfo("DCR=%08" PRIx32" \n", regval);`?
##########
File path: arch/arm/src/stm32f7/stm32_qspi.c
##########
@@ -1939,7 +1939,7 @@ static void qspi_setmode(struct qspi_dev_s *dev, enum qspi_mode_e mode)
}
qspi_putreg(priv, regval, STM32_QUADSPI_DCR_OFFSET);
- spiinfo("DCR=%08x\n", regval);
+ spiinfo("DCR=%08lx\n", regval);
Review comment:
BTW, shouldn't this be `spiinfo("DCR=%08" PRIx32 "\n", regval);`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2791: stm32f7/stm32_qspi.c: Fix warning of format strings
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2791:
URL: https://github.com/apache/incubator-nuttx/pull/2791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #2791: stm32f7/stm32_qspi.c: Fix warning of format strings
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #2791:
URL: https://github.com/apache/incubator-nuttx/pull/2791#discussion_r569051319
##########
File path: arch/arm/src/stm32f7/stm32_qspi.c
##########
@@ -1939,7 +1939,7 @@ static void qspi_setmode(struct qspi_dev_s *dev, enum qspi_mode_e mode)
}
qspi_putreg(priv, regval, STM32_QUADSPI_DCR_OFFSET);
- spiinfo("DCR=%08x\n", regval);
+ spiinfo("DCR=%08lx\n", regval);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org