[GitHub] [cordova-plugin-inappbrowser] dpa99c commented on issue #325: iPhone X support

[GitBox <gi...@apache.org>]

dpa99c commented on issue #325: iPhone X support
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/325#issuecomment-469318202
 
 
   @mosababubakr 
   
   > 1- The prvious issue (#424) in master version that you solved still appear in this popup-bridge plugin.
   
   The fix which I committed to `cordova-plugin-inappbrowser` for #424 has not been merged into `cordova-plugin-inappbrowser-popupbridge`.
   
   Note that `cordova-plugin-inappbrowser-popupbridge` is a fork which I created for my own specific needs, so is not a fully maintained fork of this plugin.
   
   > 2- if you try to open inappbrowser and you are using the option hidden=yes, and your background is dark and using preference name="StatusBarStyle" value="blacktranslucent" , then: the status bar become in light color before the window appear (before inappbrowser.show) take action.
   
   Status bar color is not an issue for me because in the app in which I use `cordova-plugin-inappbrowser-popupbridge` in production, the main app status bar colour is also light so matches the inappbrowser.
   
   > (in master version the status bar work correctly, but it conflict with upper side in inappbrowser).
   
   `cordova-plugin-inappbrowser-popupbridge` has been fixed so that the statusbar height is set to the default and only works if `cordova-plugin-statusbar` is also present (which it is in my app). It has the effect of making the statusbar height 40px on iPhone X family devices and 20px non-iPhone X family, which resolves the issue in my app:
   
   <img width="300" src="https://user-images.githubusercontent.com/2345062/53746628-87286280-3e99-11e9-9949-ee1d7c223633.png" />
   <img width="300" src="https://user-images.githubusercontent.com/2345062/53746734-c060d280-3e99-11e9-8425-e98268a89023.png"/>
   
   However, this statusbar is also applied in landscape orientation, which is fine for non-iPhone X family, but means on iPhone X family the status is displayed when it should be hidden (as it is in the main app Webview by `cordova-plugin-statusbar`):
   
   <img width="500" src="https://user-images.githubusercontent.com/2345062/53746923-12095d00-3e9a-11e9-8827-9e8ff202b38c.png"/>
   <img width="500" src="https://user-images.githubusercontent.com/2345062/53746925-12a1f380-3e9a-11e9-98a0-00e7d503a524.png"/>
   
   
   This is not a problem for me as my app is fixed in portrait, however it could do with fixing for generic use.
   
   The above screenshots have been created using the [`iphonex` branch of my `cordova-plugin-inappbrowser-popup-bridge-test` test app ](https://github.com/dpa99c/cordova-plugin-inappbrowser-popup-bridge-test/tree/iphonex).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org