You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/15 06:47:53 UTC

[GitHub] [flink] JingGe commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

JingGe commented on code in PR #20140:
URL: https://github.com/apache/flink/pull/20140#discussion_r921863300


##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java:
##########
@@ -53,7 +52,6 @@
  * Visitor to walk a Expression AST. Produces a String that can be used to pushdown the filter,
  * return Optional.empty() if we cannot pushdown the filter.
  */
-@Public

Review Comment:
   It is not allowed to change public interface. Please check [FLIP-196: Source API stability guarantees](https://cwiki.apache.org/confluence/display/FLINK/FLIP-196%3A+Source+API+stability+guarantees) for more information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org