You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/27 16:56:58 UTC
[GitHub] [beam] milancermak opened a new pull request #12953: Minor programming guide improvements
milancermak opened a new pull request #12953:
URL: https://github.com/apache/beam/pull/12953
While going through the programming guide, I found two small things that can be improved.
First is in the [Windowing with bounded PCollections](https://beam.apache.org/documentation/programming-guide/#windowing-bounded-collections) section. The description mentions reading using `TextIO` but the images display reading from a database table via Kafka IO.
I've updated both diagrams (there's also a slight change in the text) to better reflect the content in the section.
Here's the "unwindowed" before & after:
<img width="1170" alt="unwindowed-before" src="https://user-images.githubusercontent.com/184055/94370803-9f964880-00e1-11eb-893c-1517f07cfe5e.png">
<img width="1176" alt="unwindowed-after" src="https://user-images.githubusercontent.com/184055/94370806-a329cf80-00e1-11eb-8b5f-0f3c2ba9d193.png">
Here's the "windowing" before & after:
<img width="1185" alt="windowing-before" src="https://user-images.githubusercontent.com/184055/94370822-be94da80-00e1-11eb-8e93-95f44ca93afb.png">
<img width="1193" alt="windowing-after" src="https://user-images.githubusercontent.com/184055/94370828-c05e9e00-00e1-11eb-99b8-ffbe1febf70b.png">
The second change is a minor one in the [Setting a trigger](https://beam.apache.org/documentation/programming-guide/#setting-a-trigger) section. The python example uses a code snippet from a test suite, but it is wrong with regards to the text - the text (and the Java snippet) use a one minute `afterProcessing` trigger whereas the incorrect snippet uses a 10 minute trigget (`10 * 60`). I've copy-pasted the whole code snippet and removed the now obsolete commands from the test suite.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] milancermak commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
milancermak commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705519191
Can you please provide some guidance on how & where?
I found [this StackOverflow](https://stackoverflow.com/questions/4697100/accessibility-recommended-alt-text-convention-for-svg-and-mathml) post, but the SVGs already have a `title` tag that seems to be transformed into an `alt` attribute on the `img` tag in the rendered HTML. Should I update that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rosetn commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
rosetn commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705711800
Looking closer at the file, I see that there already is alt text that I've missed. Sorry about that! On this site and flavor of markdown, you can specify the alt text directly in the .md file, in the following format: 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #12953:
URL: https://github.com/apache/beam/pull/12953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rosetn edited a comment on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
rosetn edited a comment on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705711800
Looking closer at the file, I see that there already is alt text that I've missed. Sorry about that! On this site and flavor of markdown, you can specify the alt text directly in the .md file, in the following format (with no spaces): ! [Alternative text] (/images/image-name.svg)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rosetn commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
rosetn commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705245981
Thanks, Milan! Looks good. Can you add the `alt` attribute to the SVG files and provide some brief alternative text?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rosetn commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
rosetn commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705711800
Looking closer at the file, I see that there already is alt text that I've missed. Sorry about that! On this site and flavor of markdown, you can specify the alt text directly in the .md file, in the following format: 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #12953:
URL: https://github.com/apache/beam/pull/12953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rosetn commented on a change in pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
rosetn commented on a change in pull request #12953:
URL: https://github.com/apache/beam/pull/12953#discussion_r499071428
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -3554,7 +3554,7 @@ Now, consider the same pipeline, but using a windowing function:
**Figure 5:** `GroupByKey` and `ParDo` with windowing, on a bounded collection.
-As before, the pipeline creates a bounded `PCollection` of key/value pairs. We
+As before, the pipeline creates a bounded `PCollection` of file lines. We
Review comment:
I'd replace "of file lines" with "by reading lines from a file using `TextIO`." I think how you have it earlier is clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705725442
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705725442
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] milancermak commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
milancermak commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-703108161
Hi, thank you for the review.
Since Figure 3 pertains to an unbounded collection, to me it makes sense to me to have a KafkaIO transform there. I've changed the diagram so that it reads from a Kafka topic instead of a database table. That we the text doesn't have to updated either. Here's the before & after.
<img width="1104" alt="windowing-pipeline-unbounded-before" src="https://user-images.githubusercontent.com/184055/94993430-73b31100-0580-11eb-92ef-2ab0c4d37058.png">
<img width="1117" alt="windowing-pipeline-unbounded-after" src="https://user-images.githubusercontent.com/184055/94993431-757cd480-0580-11eb-80c9-1347a7dc355d.png">
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-703110493
# [Codecov](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=h1) Report
> Merging [#12953](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/934e6e6a37a6e685a15876093049f11a238870aa?el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12953 +/- ##
==========================================
+ Coverage 82.35% 82.49% +0.14%
==========================================
Files 455 454 -1
Lines 54650 54797 +147
==========================================
+ Hits 45006 45204 +198
+ Misses 9644 9593 -51
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/metrics/execution.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9leGVjdXRpb24ucHk=) | `87.40% <0.00%> (-2.87%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWMucHk=) | `95.31% <0.00%> (-1.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9jZWxscy5weQ==) | `80.73% <0.00%> (-1.32%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `79.40% <0.00%> (-1.32%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=) | `88.75% <0.00%> (-0.60%)` | :arrow_down: |
| [...dks/python/apache\_beam/metrics/monitoring\_infos.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tb25pdG9yaW5nX2luZm9zLnB5) | `96.64% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | `96.75% <0.00%> (-0.45%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.98% <0.00%> (-0.17%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=footer). Last update [934e6e6...19e16b1](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] milancermak commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
milancermak commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-699660013
R: @melap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-702475145
R: @rosetn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-703110493
# [Codecov](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=h1) Report
> Merging [#12953](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/934e6e6a37a6e685a15876093049f11a238870aa?el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12953 +/- ##
==========================================
+ Coverage 82.35% 82.49% +0.14%
==========================================
Files 455 454 -1
Lines 54650 54797 +147
==========================================
+ Hits 45006 45204 +198
+ Misses 9644 9593 -51
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/metrics/execution.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9leGVjdXRpb24ucHk=) | `87.40% <0.00%> (-2.87%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWMucHk=) | `95.31% <0.00%> (-1.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9jZWxscy5weQ==) | `80.73% <0.00%> (-1.32%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `79.40% <0.00%> (-1.32%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=) | `88.75% <0.00%> (-0.60%)` | :arrow_down: |
| [...dks/python/apache\_beam/metrics/monitoring\_infos.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tb25pdG9yaW5nX2luZm9zLnB5) | `96.64% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | `96.75% <0.00%> (-0.45%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.98% <0.00%> (-0.17%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/beam/pull/12953/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=footer). Last update [934e6e6...19e16b1](https://codecov.io/gh/apache/beam/pull/12953?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rosetn edited a comment on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
rosetn edited a comment on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705711800
Looking closer at the file, I see that there already is alt text that I've missed. Sorry about that! On this site and flavor of markdown, you can specify the alt text directly in the .md file, in the following format (with no spaces): ! [Alternative text] (/images/image-name.svg)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] milancermak commented on pull request #12953: Minor programming guide improvements
Posted by GitBox <gi...@apache.org>.
milancermak commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-705519191
Can you please provide some guidance on how & where?
I found [this StackOverflow](https://stackoverflow.com/questions/4697100/accessibility-recommended-alt-text-convention-for-svg-and-mathml) post, but the SVGs already have a `title` tag that seems to be transformed into an `alt` attribute on the `img` tag in the rendered HTML. Should I update that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org