You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/07/12 13:18:34 UTC

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #524: nimble/mesh: Increase transaction ID after sending unack message

rymanluk commented on a change in pull request #524: nimble/mesh: Increase transaction ID after sending unack message
URL: https://github.com/apache/mynewt-nimble/pull/524#discussion_r302977343
 
 

 ##########
 File path: nimble/host/mesh/src/model_cli.c
 ##########
 @@ -176,6 +176,8 @@ int bt_mesh_gen_onoff_set(u16_t net_idx, u16_t addr, u16_t app_idx,
 	}
 
 	if (!state) {
+		/* Increase transaction ID after sending set_unack message */
+		transaction_id++;
 
 Review comment:
   Maybe we have increment it in `done:` label instead here and in status callback? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services