You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mklumpen (via GitHub)" <gi...@apache.org> on 2024/10/10 23:15:20 UTC
[PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
mklumpen opened a new pull request, #30577:
URL: https://github.com/apache/superset/pull/30577
### SUMMARY
The issue is caused by a custom style in the forked version of cosmo bootswatch.less that was added in the original [multi-panel sqllab PR](https://github.com/apache/superset/pull/514/). The style overrides the caret style that is part of the bootstrap dropdown.less and references the FontAwesome font which is no longer included. The fix updates the bootswatch style to use Glyphicons down-chevron icon that is similar to the icons used in the React implementations. An alternative would be to remove the style from bootswatch completely, which can be seen in the ALTERNATE screenshot below.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
ALTERNATE: would be implemented by completely removing the caret style in the forked bootswatch.less and allowing boostrap dropdowns.less style to be applied:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #30514
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30577:
URL: https://github.com/apache/superset/pull/30577#issuecomment-2895165894
@rusackas Ephemeral environment spinning up at http://35.87.182.89:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30577:
URL: https://github.com/apache/superset/pull/30577#issuecomment-2895489162
Looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30577:
URL: https://github.com/apache/superset/pull/30577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30577:
URL: https://github.com/apache/superset/pull/30577#issuecomment-2895134627
@rusackas Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/15142992507). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "mklumpen (via GitHub)" <gi...@apache.org>.
mklumpen closed pull request #30577: fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514)
URL: https://github.com/apache/superset/pull/30577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30577:
URL: https://github.com/apache/superset/pull/30577#issuecomment-2895132814
Wow, is the fix really just _deleting_ some style? I love it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "mklumpen (via GitHub)" <gi...@apache.org>.
mklumpen commented on PR #30577:
URL: https://github.com/apache/superset/pull/30577#issuecomment-2842780558
It does look like glyphicons-halflings is loaded as part of cosmo in superset-frontend/src/assets/stylesheets/less/cosmo/variables.less, so should be available to all, but I have updated the code in favor of the alternate approach, which removes the style altogether.
Let me know if I need to update the description in the pull request to swap the proposed and alternate solutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30577:
URL: https://github.com/apache/superset/pull/30577#issuecomment-2768086445
I don't think most people will have `Glyphicons Halflings` installed, right? Or is that buried somewhere in the dependencies I'm not aware of?
I'm all for the Alternate approach (less CSS is better). Ultimately this should (and will) all be ported to React views and stop relying on server-templated pages, so we can remove Cosmo/bootstrap entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514) [superset]
Posted by "mklumpen (via GitHub)" <gi...@apache.org>.
mklumpen closed pull request #30577: fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (#30514)
URL: https://github.com/apache/superset/pull/30577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org