You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/19 00:56:21 UTC
[kudu-CR] [mini-cluster] built-in NTP client configuration mode
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15238
Change subject: [mini-cluster] built-in NTP client configuration mode
......................................................................
[mini-cluster] built-in NTP client configuration mode
This patch introduces configuration mode for the built-in NTP client
in the scope of Kudu external mini-cluster.
Prior to this patch, the only way to configure the built-in NTP client
in a Kudu external mini-cluster was using all available test NTP servers
as reference servers. With this patch, it's now possible to point
different tablet servers and masters to different NTP servers run
as a part of a test mini-cluster.
A follow-up patch will use the newly introduced mode for a new test.
Change-Id: I88561f757678b664b810b54a27317cac99297403
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 65 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/15238/1
--
To view, visit http://gerrit.cloudera.org:8080/15238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88561f757678b664b810b54a27317cac99297403
Gerrit-Change-Number: 15238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-cluster] built-in NTP client configuration mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15238 )
Change subject: [mini-cluster] built-in NTP client configuration mode
......................................................................
[mini-cluster] built-in NTP client configuration mode
This patch introduces configuration mode for the built-in NTP client
in the scope of Kudu external mini-cluster.
Prior to this patch, the only way to configure the built-in NTP client
in a Kudu external mini-cluster was using all available test NTP servers
as reference servers. With this patch, it's now possible to point
different tablet servers and masters to different NTP servers run
as a part of a test mini-cluster.
A follow-up patch will use the newly introduced mode for a new test.
Change-Id: I88561f757678b664b810b54a27317cac99297403
Reviewed-on: http://gerrit.cloudera.org:8080/15238
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 66 insertions(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88561f757678b664b810b54a27317cac99297403
Gerrit-Change-Number: 15238
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [mini-cluster] built-in NTP client configuration mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15238
to look at the new patch set (#2).
Change subject: [mini-cluster] built-in NTP client configuration mode
......................................................................
[mini-cluster] built-in NTP client configuration mode
This patch introduces configuration mode for the built-in NTP client
in the scope of Kudu external mini-cluster.
Prior to this patch, the only way to configure the built-in NTP client
in a Kudu external mini-cluster was using all available test NTP servers
as reference servers. With this patch, it's now possible to point
different tablet servers and masters to different NTP servers run
as a part of a test mini-cluster.
A follow-up patch will use the newly introduced mode for a new test.
Change-Id: I88561f757678b664b810b54a27317cac99297403
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 66 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/15238/2
--
To view, visit http://gerrit.cloudera.org:8080/15238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88561f757678b664b810b54a27317cac99297403
Gerrit-Change-Number: 15238
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [mini-cluster] built-in NTP client configuration mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15238 )
Change subject: [mini-cluster] built-in NTP client configuration mode
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h
File src/kudu/mini-cluster/external_mini_cluster.h:
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h@101
PS1, Line 101: to configure
: // the
> Replace with "for its"
Done
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h@112
PS1, Line 112: robing
> robin
Done
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h@233
PS1, Line 233: // The way how the built-in NTP client is configured given the set of NTP
: // servers run by the mini-cluster.
> Replace with "Mapping of NTP servers to built-in NTP client for each Kudu s
Done
--
To view, visit http://gerrit.cloudera.org:8080/15238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88561f757678b664b810b54a27317cac99297403
Gerrit-Change-Number: 15238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 03:38:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mini-cluster] built-in NTP client configuration mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15238 )
Change subject: [mini-cluster] built-in NTP client configuration mode
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h
File src/kudu/mini-cluster/external_mini_cluster.h:
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h@101
PS1, Line 101: to configure
: // the
Replace with "for its"
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h@112
PS1, Line 112: robing
robin
http://gerrit.cloudera.org:8080/#/c/15238/1/src/kudu/mini-cluster/external_mini_cluster.h@233
PS1, Line 233: // The way how the built-in NTP client is configured given the set of NTP
: // servers run by the mini-cluster.
Replace with "Mapping of NTP servers to built-in NTP client for each Kudu server".
Also note that it's only relevant if num_ntp_servers > 0.
--
To view, visit http://gerrit.cloudera.org:8080/15238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88561f757678b664b810b54a27317cac99297403
Gerrit-Change-Number: 15238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 02:07:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mini-cluster] built-in NTP client configuration mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15238 )
Change subject: [mini-cluster] built-in NTP client configuration mode
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88561f757678b664b810b54a27317cac99297403
Gerrit-Change-Number: 15238
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 07:50:28 +0000
Gerrit-HasComments: No