You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Ivan Fedorenkov <iv...@gmail.com> on 2021/08/11 12:20:44 UTC
IGNITE-15256 request for review
Dear Ignite Devs,
I would like to contribute a fix that addresses a bug associated with
registration of user types by Ignite Java Thin Client. Could someone please
review the code? https://github.com/apache/ignite/pull/9307
Problem description: when Java Thin Client reestablishes connection to
Ignite and invokes a Service API method with Externalizable input parameter
server node may throw ClassNotFoundException and client marks the
connection as broken and tries to open a new one.
Root cause: Ignite server nodes may lose all the registered user types
after restart if Ignite Working Dir gets deleted or cluster moves to
another set of hosts. Clients, at the same time, believe that they have
already registered their user types and they skip registration after
reconnecting.
Please note that this is my first PR into Ignite repo and I may easily miss
some important details.
Best regards,
Ivan Fedorenkov
Re: IGNITE-15256 request for review
Posted by Ivan Fedorenkov <iv...@gmail.com>.
Thank you guys!
чт, 12 авг. 2021 г. в 14:04, Pavel Tupitsyn <pt...@apache.org>:
> Hi Ivan,
>
> Thank you for your contribution!
> Please see my comments in JIRA.
>
> On Wed, Aug 11, 2021 at 5:54 PM Mirza Aliev <al...@gmail.com> wrote:
>
> > Helo Ivan! Thank you for your effort!
> >
> > Here [1] you can find info about the process of contributing to Apache
> > Ignite.
> > As Krill said before, you need to get "green visa", which means that you
> > need to run TeamCity bot and receive no blockers (see "Submitting for
> > Review" section here [1])
> >
> > Feel free to ask questions, if something is unclear.
> >
> > [1] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >
> > ср, 11 авг. 2021 г. в 16:52, ткаленко кирилл <tk...@yandex.ru>:
> >
> > > Hi, in the beginning it is worth getting a green visa.
> > >
> > > 11.08.2021, 15:21, "Ivan Fedorenkov" <iv...@gmail.com>:
> > > > Dear Ignite Devs,
> > > >
> > > > I would like to contribute a fix that addresses a bug associated with
> > > > registration of user types by Ignite Java Thin Client. Could someone
> > > please
> > > > review the code? https://github.com/apache/ignite/pull/9307
> > > >
> > > > Problem description: when Java Thin Client reestablishes connection
> to
> > > > Ignite and invokes a Service API method with Externalizable input
> > > parameter
> > > > server node may throw ClassNotFoundException and client marks the
> > > > connection as broken and tries to open a new one.
> > > >
> > > > Root cause: Ignite server nodes may lose all the registered user
> types
> > > > after restart if Ignite Working Dir gets deleted or cluster moves to
> > > > another set of hosts. Clients, at the same time, believe that they
> have
> > > > already registered their user types and they skip registration after
> > > > reconnecting.
> > > >
> > > > Please note that this is my first PR into Ignite repo and I may
> easily
> > > miss
> > > > some important details.
> > > >
> > > > Best regards,
> > > > Ivan Fedorenkov
> > >
> >
>
Re: IGNITE-15256 request for review
Posted by Pavel Tupitsyn <pt...@apache.org>.
Hi Ivan,
Thank you for your contribution!
Please see my comments in JIRA.
On Wed, Aug 11, 2021 at 5:54 PM Mirza Aliev <al...@gmail.com> wrote:
> Helo Ivan! Thank you for your effort!
>
> Here [1] you can find info about the process of contributing to Apache
> Ignite.
> As Krill said before, you need to get "green visa", which means that you
> need to run TeamCity bot and receive no blockers (see "Submitting for
> Review" section here [1])
>
> Feel free to ask questions, if something is unclear.
>
> [1] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>
> ср, 11 авг. 2021 г. в 16:52, ткаленко кирилл <tk...@yandex.ru>:
>
> > Hi, in the beginning it is worth getting a green visa.
> >
> > 11.08.2021, 15:21, "Ivan Fedorenkov" <iv...@gmail.com>:
> > > Dear Ignite Devs,
> > >
> > > I would like to contribute a fix that addresses a bug associated with
> > > registration of user types by Ignite Java Thin Client. Could someone
> > please
> > > review the code? https://github.com/apache/ignite/pull/9307
> > >
> > > Problem description: when Java Thin Client reestablishes connection to
> > > Ignite and invokes a Service API method with Externalizable input
> > parameter
> > > server node may throw ClassNotFoundException and client marks the
> > > connection as broken and tries to open a new one.
> > >
> > > Root cause: Ignite server nodes may lose all the registered user types
> > > after restart if Ignite Working Dir gets deleted or cluster moves to
> > > another set of hosts. Clients, at the same time, believe that they have
> > > already registered their user types and they skip registration after
> > > reconnecting.
> > >
> > > Please note that this is my first PR into Ignite repo and I may easily
> > miss
> > > some important details.
> > >
> > > Best regards,
> > > Ivan Fedorenkov
> >
>
Re: IGNITE-15256 request for review
Posted by Mirza Aliev <al...@gmail.com>.
Helo Ivan! Thank you for your effort!
Here [1] you can find info about the process of contributing to Apache
Ignite.
As Krill said before, you need to get "green visa", which means that you
need to run TeamCity bot and receive no blockers (see "Submitting for
Review" section here [1])
Feel free to ask questions, if something is unclear.
[1] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
ср, 11 авг. 2021 г. в 16:52, ткаленко кирилл <tk...@yandex.ru>:
> Hi, in the beginning it is worth getting a green visa.
>
> 11.08.2021, 15:21, "Ivan Fedorenkov" <iv...@gmail.com>:
> > Dear Ignite Devs,
> >
> > I would like to contribute a fix that addresses a bug associated with
> > registration of user types by Ignite Java Thin Client. Could someone
> please
> > review the code? https://github.com/apache/ignite/pull/9307
> >
> > Problem description: when Java Thin Client reestablishes connection to
> > Ignite and invokes a Service API method with Externalizable input
> parameter
> > server node may throw ClassNotFoundException and client marks the
> > connection as broken and tries to open a new one.
> >
> > Root cause: Ignite server nodes may lose all the registered user types
> > after restart if Ignite Working Dir gets deleted or cluster moves to
> > another set of hosts. Clients, at the same time, believe that they have
> > already registered their user types and they skip registration after
> > reconnecting.
> >
> > Please note that this is my first PR into Ignite repo and I may easily
> miss
> > some important details.
> >
> > Best regards,
> > Ivan Fedorenkov
>
Re: IGNITE-15256 request for review
Posted by ткаленко кирилл <tk...@yandex.ru>.
Hi, in the beginning it is worth getting a green visa.
11.08.2021, 15:21, "Ivan Fedorenkov" <iv...@gmail.com>:
> Dear Ignite Devs,
>
> I would like to contribute a fix that addresses a bug associated with
> registration of user types by Ignite Java Thin Client. Could someone please
> review the code? https://github.com/apache/ignite/pull/9307
>
> Problem description: when Java Thin Client reestablishes connection to
> Ignite and invokes a Service API method with Externalizable input parameter
> server node may throw ClassNotFoundException and client marks the
> connection as broken and tries to open a new one.
>
> Root cause: Ignite server nodes may lose all the registered user types
> after restart if Ignite Working Dir gets deleted or cluster moves to
> another set of hosts. Clients, at the same time, believe that they have
> already registered their user types and they skip registration after
> reconnecting.
>
> Please note that this is my first PR into Ignite repo and I may easily miss
> some important details.
>
> Best regards,
> Ivan Fedorenkov