You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "somandal (via GitHub)" <gi...@apache.org> on 2023/03/03 18:56:21 UTC

[GitHub] [pinot] somandal commented on a diff in pull request #10373: [Query Killing] Enhance gc related logic, refactor logging

somandal commented on code in PR #10373:
URL: https://github.com/apache/pinot/pull/10373#discussion_r1124894555


##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -756,10 +777,19 @@ private void killMostExpensiveQuery() {
                     " Query %s got killed because using %d bytes of memory on %s, exceeding the quota",
                     maxUsageTuple._queryId, maxUsageTuple.getAllocatedBytes(), _instanceType)));
             interruptRunnerThread(maxUsageTuple.getAnchorThread());
+            LOGGER.error("Heap used bytes {} exceeds critical level {}", _usedBytes, _criticalLevel);

Review Comment:
   nit: should these logs be modified to print `_criticalLevelAfterGC` instead of `_criticalLevel`? or perhaps add `_criticalLevelAfterGC` to the log too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org