You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/16 18:20:41 UTC

[GitHub] [beam] KevinGG commented on a change in pull request #13335: [BEAM-10921]: Fix BEAM-10921 and underlying issues

KevinGG commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r524478709



##########
File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -510,11 +529,10 @@ def track_user_pipelines(self):
     function also clears up internal states for those anonymous pipelines once
     all their PCollections are anonymous.
     """
-    self._tracked_user_pipelines = set()

Review comment:
       With this change, what if a user pipeline is no longer in scope, will it get cleared from the `self._tracked_user_pipelines`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org