You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Paul Hammant <Pa...@yahoo.com> on 2001/08/13 23:36:13 UTC
[PATCH] Logkit - building without javax.jms and javax.sql
Compiling Logkit is fails if you don't have javax.sql and javax.jms in lib.
Patch follows.
- PH
C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
Index: build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
retrieving revision 1.38
diff -r1.38 build.xml
155a156,163
> <available property="javax.sql.present"
> classname="javax.sql.DataSource"
> classpathref="project.class.path" />
>
> <available property="javax.jms.present"
> classname="javax.jms.TopicConnection"
> classpathref="project.class.path" />
>
167a176,179
> <exclude name="org/apache/log/output/db/**"
> unless="javax.sql.present"/>
> <exclude name="org/apache/log/output/jms/**"
> unless="javax.jms.present"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Charles Benett <ch...@benett1.demon.co.uk>.
Peter Donald wrote:
>
> On Thu, 16 Aug 2001 21:06, Charles Benett wrote:
> > Peter Donald wrote:
> > > On Thu, 16 Aug 2001 19:19, Paul Hammant wrote:
> > > > Trying to reapply this patch (as per invitation to commit it myself)
> > > > and it does not work. Depite trying numerous combinations of the
> > > > <exclude> for org/apache/log/output/db/**, it never excludes the
> > > > package from compilation !!?!
> > > >
> > > > Can somone else test this to make sure I am not going insane..
> > >
> > > Try adding
> > > <exclude name="org/apache/log/output/test/DBTargetTestlet.java"
> > > unless="javax.sql.present"/>
> > >
> > > The compiler is probably trying to include the classes because they are
> > > referenced from that file.
> >
> > Done. But there's still an issue with junit - build scripts aren't
> > picking the jar.
>
> hmm .. seems to work fine here. Picks up junit from
>
> ../jakarta-avalon/tools/lib/junit-3.7.jar
>
I've just patched the buildfile to include tools.class.path in the javac
classpath.
Charles
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Peter Donald <do...@apache.org>.
On Thu, 16 Aug 2001 21:06, Charles Benett wrote:
> Peter Donald wrote:
> > On Thu, 16 Aug 2001 19:19, Paul Hammant wrote:
> > > Trying to reapply this patch (as per invitation to commit it myself)
> > > and it does not work. Depite trying numerous combinations of the
> > > <exclude> for org/apache/log/output/db/**, it never excludes the
> > > package from compilation !!?!
> > >
> > > Can somone else test this to make sure I am not going insane..
> >
> > Try adding
> > <exclude name="org/apache/log/output/test/DBTargetTestlet.java"
> > unless="javax.sql.present"/>
> >
> > The compiler is probably trying to include the classes because they are
> > referenced from that file.
>
> Done. But there's still an issue with junit - build scripts aren't
> picking the jar.
hmm .. seems to work fine here. Picks up junit from
../jakarta-avalon/tools/lib/junit-3.7.jar
>
> Charles
>
> > > - Paul
> > >
> > > Paul Hammant wrote:
> > > > Compiling Logkit is fails if you don't have javax.sql and javax.jms
> > > > in lib.
> > > >
> > > > Patch follows.
> > > >
> > > > - PH
> > > >
> > > > C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
> > > > Index: build.xml
> > > > ===================================================================
> > > > RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
> > > > retrieving revision 1.38
> > > > diff -r1.38 build.xml
> > > > 155a156,163
> > > >
> > > > > <available property="javax.sql.present"
> > > > > classname="javax.sql.DataSource"
> > > > > classpathref="project.class.path" />
> > > > >
> > > > > <available property="javax.jms.present"
> > > > > classname="javax.jms.TopicConnection"
> > > > > classpathref="project.class.path" />
> > > >
> > > > 167a176,179
> > > >
> > > > > <exclude name="org/apache/log/output/db/**"
> > > > > unless="javax.sql.present"/> >
> > > >
> > > > <exclude name="org/apache/log/output/jms/**"
> > > >
> > > > > unless="javax.jms.present"/>
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > > > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
> >
> > --
> > Cheers,
> >
> > Pete
> >
> > *-----------------------------------------------------*
> > * "Faced with the choice between changing one's mind, *
> > * and proving that there is no need to do so - almost *
> > * everyone gets busy on the proof." *
> > * - John Kenneth Galbraith *
> > *-----------------------------------------------------*
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
--
Cheers,
Pete
*-----------------------------------------------------*
* "Faced with the choice between changing one's mind, *
* and proving that there is no need to do so - almost *
* everyone gets busy on the proof." *
* - John Kenneth Galbraith *
*-----------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Charles Benett <ch...@benett1.demon.co.uk>.
Peter Donald wrote:
>
> On Thu, 16 Aug 2001 19:19, Paul Hammant wrote:
> > Trying to reapply this patch (as per invitation to commit it myself) and
> > it does not work. Depite trying numerous combinations of the <exclude>
> > for org/apache/log/output/db/**, it never excludes the package from
> > compilation !!?!
> >
> > Can somone else test this to make sure I am not going insane..
>
> Try adding
> <exclude name="org/apache/log/output/test/DBTargetTestlet.java"
> unless="javax.sql.present"/>
>
> The compiler is probably trying to include the classes because they are
> referenced from that file.
Done. But there's still an issue with junit - build scripts aren't
picking the jar.
Charles
>
> >
> > - Paul
> >
> > Paul Hammant wrote:
> > > Compiling Logkit is fails if you don't have javax.sql and javax.jms in
> > > lib.
> > >
> > > Patch follows.
> > >
> > > - PH
> > >
> > > C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
> > > Index: build.xml
> > > ===================================================================
> > > RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
> > > retrieving revision 1.38
> > > diff -r1.38 build.xml
> > > 155a156,163
> > >
> > > > <available property="javax.sql.present"
> > > > classname="javax.sql.DataSource"
> > > > classpathref="project.class.path" />
> > > >
> > > > <available property="javax.jms.present"
> > > > classname="javax.jms.TopicConnection"
> > > > classpathref="project.class.path" />
> > >
> > > 167a176,179
> > >
> > > > <exclude name="org/apache/log/output/db/**"
> > > > unless="javax.sql.present"/> >
> > >
> > > <exclude name="org/apache/log/output/jms/**"
> > >
> > > > unless="javax.jms.present"/>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
> --
> Cheers,
>
> Pete
>
> *-----------------------------------------------------*
> * "Faced with the choice between changing one's mind, *
> * and proving that there is no need to do so - almost *
> * everyone gets busy on the proof." *
> * - John Kenneth Galbraith *
> *-----------------------------------------------------*
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Peter Donald <do...@apache.org>.
On Thu, 16 Aug 2001 19:19, Paul Hammant wrote:
> Trying to reapply this patch (as per invitation to commit it myself) and
> it does not work. Depite trying numerous combinations of the <exclude>
> for org/apache/log/output/db/**, it never excludes the package from
> compilation !!?!
>
> Can somone else test this to make sure I am not going insane..
Try adding
<exclude name="org/apache/log/output/test/DBTargetTestlet.java"
unless="javax.sql.present"/>
The compiler is probably trying to include the classes because they are
referenced from that file.
>
> - Paul
>
> Paul Hammant wrote:
> > Compiling Logkit is fails if you don't have javax.sql and javax.jms in
> > lib.
> >
> > Patch follows.
> >
> > - PH
> >
> > C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
> > Index: build.xml
> > ===================================================================
> > RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
> > retrieving revision 1.38
> > diff -r1.38 build.xml
> > 155a156,163
> >
> > > <available property="javax.sql.present"
> > > classname="javax.sql.DataSource"
> > > classpathref="project.class.path" />
> > >
> > > <available property="javax.jms.present"
> > > classname="javax.jms.TopicConnection"
> > > classpathref="project.class.path" />
> >
> > 167a176,179
> >
> > > <exclude name="org/apache/log/output/db/**"
> > > unless="javax.sql.present"/> >
> >
> > <exclude name="org/apache/log/output/jms/**"
> >
> > > unless="javax.jms.present"/>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
--
Cheers,
Pete
*-----------------------------------------------------*
* "Faced with the choice between changing one's mind, *
* and proving that there is no need to do so - almost *
* everyone gets busy on the proof." *
* - John Kenneth Galbraith *
*-----------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Peter Donald <do...@apache.org>.
On Tue, 14 Aug 2001 17:09, Paul Hammant wrote:
> >Looks good ... couldn't you patch this yourself ... ? ;)
>
> Err <cough/> I did not seek a new password after the May Apache hack,
> when all committers were disabled. Then I was concentrating too much on
> Jesktop to be useful to Avalon ;-)
Sounds like the perfect opportunity to turn that around now then ;)
--
Cheers,
Pete
*-----------------------------------------------------*
* "Faced with the choice between changing one's mind, *
* and proving that there is no need to do so - almost *
* everyone gets busy on the proof." *
* - John Kenneth Galbraith *
*-----------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Paul Hammant <Pa...@yahoo.com>.
>
>
>Looks good ... couldn't you patch this yourself ... ? ;)
>
Err <cough/> I did not seek a new password after the May Apache hack,
when all committers were disabled. Then I was concentrating too much on
Jesktop to be useful to Avalon ;-)
-PH
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Peter Donald <do...@apache.org>.
Looks good ... couldn't you patch this yourself ... ? ;)
On Tue, 14 Aug 2001 07:36, Paul Hammant wrote:
> Compiling Logkit is fails if you don't have javax.sql and javax.jms in lib.
>
> Patch follows.
>
> - PH
>
> C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
> retrieving revision 1.38
> diff -r1.38 build.xml
> 155a156,163
>
> > <available property="javax.sql.present"
> > classname="javax.sql.DataSource"
> > classpathref="project.class.path" />
> >
> > <available property="javax.jms.present"
> > classname="javax.jms.TopicConnection"
> > classpathref="project.class.path" />
>
> 167a176,179
>
> > <exclude name="org/apache/log/output/db/**"
> > unless="javax.sql.present"/>
> > <exclude name="org/apache/log/output/jms/**"
> > unless="javax.jms.present"/>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
--
Cheers,
Pete
*-----------------------------------------------------*
* "Faced with the choice between changing one's mind, *
* and proving that there is no need to do so - almost *
* everyone gets busy on the proof." *
* - John Kenneth Galbraith *
*-----------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Charles Benett <ch...@benett1.demon.co.uk>.
Paul Hammant wrote:
>
> Trying to reapply this patch (as per invitation to commit it myself) and
> it does not work. Depite trying numerous combinations of the <exclude>
> for org/apache/log/output/db/**, it never excludes the package from
> compilation !!?!
>
> Can somone else test this to make sure I am not going insane..
NO - you are dead right. I tried applying your patch yesturday and got
exactly the same error!
I just assumed it was me being slow!
Charles
>
> - Paul
>
> Paul Hammant wrote:
>
> > Compiling Logkit is fails if you don't have javax.sql and javax.jms in
> > lib.
> >
> > Patch follows.
> >
> > - PH
> >
> > C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
> > Index: build.xml
> > ===================================================================
> > RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
> > retrieving revision 1.38
> > diff -r1.38 build.xml
> > 155a156,163
> > > <available property="javax.sql.present"
> > > classname="javax.sql.DataSource"
> > > classpathref="project.class.path" />
> > >
> > > <available property="javax.jms.present"
> > > classname="javax.jms.TopicConnection"
> > > classpathref="project.class.path" />
> > >
> > 167a176,179
> > > <exclude name="org/apache/log/output/db/**"
> > > unless="javax.sql.present"/> >
> > <exclude name="org/apache/log/output/jms/**"
> > > unless="javax.jms.present"/>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] Logkit - building without javax.jms and javax.sql
Posted by Paul Hammant <Pa...@yahoo.com>.
Trying to reapply this patch (as per invitation to commit it myself) and
it does not work. Depite trying numerous combinations of the <exclude>
for org/apache/log/output/db/**, it never excludes the package from
compilation !!?!
Can somone else test this to make sure I am not going insane..
- Paul
Paul Hammant wrote:
> Compiling Logkit is fails if you don't have javax.sql and javax.jms in
> lib.
>
> Patch follows.
>
> - PH
>
> C:/Apache-CVS/cvs.exe diff -r HEAD build.xml
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/jakarta-avalon-logkit/build.xml,v
> retrieving revision 1.38
> diff -r1.38 build.xml
> 155a156,163
> > <available property="javax.sql.present"
> > classname="javax.sql.DataSource"
> > classpathref="project.class.path" />
> >
> > <available property="javax.jms.present"
> > classname="javax.jms.TopicConnection"
> > classpathref="project.class.path" />
> >
> 167a176,179
> > <exclude name="org/apache/log/output/db/**"
> > unless="javax.sql.present"/> >
> <exclude name="org/apache/log/output/jms/**"
> > unless="javax.jms.present"/>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org