You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/29 21:26:00 UTC
[jira] [Commented] (DRILL-6246) Build Failing in jdbc-all artifact
[ https://issues.apache.org/jira/browse/DRILL-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596869#comment-16596869 ]
ASF GitHub Bot commented on DRILL-6246:
---------------------------------------
Ben-Zvi commented on a change in pull request #1168: DRILL-6246: Reduced the size of the jdbc-all jar file
URL: https://github.com/apache/drill/pull/1168#discussion_r213839471
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -473,6 +473,8 @@
<exclude>org/yaml/**</exclude>
<exclude>hello/**</exclude>
<exclude>webapps/**</exclude>
+ <exclude>**/org/apache/calcite/avatica/metrics/**</exclude>
+ <exclude>**/org/apache/calcite/avatica/org/**</exclude>
Review comment:
Just checked the latest code - Using these exclusions, the jar size went down from 38942905 to 37542344. (The maxsize now is 39000000).
It could be nice to reduce 1.4M ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Build Failing in jdbc-all artifact
> ----------------------------------
>
> Key: DRILL-6246
> URL: https://issues.apache.org/jira/browse/DRILL-6246
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.13.0
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
>
> * {color:#000000}It was noticed that the build was failing because of the jdbc-all artifact{color}
> * {color:#000000}The maximum compressed jar size was set to 32MB but we are currently creating a JAR a bit larger than 32MB {color}
> * {color:#000000}I compared apache drill-1.10.0, drill-1.12.0, and drill-1.13.0 (on my MacOS){color}
> * {color:#000000}jdbc-all-1.10.0 jar size: 21MB{color}
> * {color:#000000}jdbc-all-1.12.0 jar size: 27MB{color}
> * {color:#000000}jdbc-all-1.13.0 jar size: 34MB (on Linux this size is roughly 32MB){color}
> * {color:#000000}Compared then in more details jdbc-all-1.12.0 and jdbc-all-1.13.0{color}
> * {color:#000000}The bulk of the increase is attributed to the calcite artifact{color}
> * {color:#000000}Used to be 2MB (uncompressed) and now 22MB (uncompressed){color}
> * {color:#000000}It is likely an exclusion problem {color}
> * {color:#000000}The jdbc-all-1.12.0 version has only two top packages calcite/avatica/utils and calcite/avatica/remote{color}
> * {color:#000000}The jdbc-all-1.13.0 includes new packages (within calcite/avatica) metrics, proto, org/apache/, com/fasterxml, com/google{color}
> {color:#000000} {color}
> {color:#000000}I am planning to exclude these new sub-packages{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)