[GitHub] [ozone] fapifta commented on pull request #2702: HDDS-5755 EC: Refactor ECBlockOutputStreamEntry to accommodate all block group related ECBlockOuputStreams.

[GitBox <gi...@apache.org>]

fapifta commented on pull request #2702:
URL: https://github.com/apache/ozone/pull/2702#issuecomment-932686941


   @umamaheswararao you can take a look to the current state if you wish, I marked this as draft since there are still some junit tests I would like to add to it, and some things will require some polishing.
   Here is what I am tracking:
   - checkstyle for sure will fail, as there are some long lines remained
   - ECBlockoutputstreamEntry#getTotalAckedDataLenght and ECBlockoutputStreamEntry#getWrittenDataLength does not consider parity, which I believed should fail some tests, but it did not, hence I would like to add some new tests before touching that (if you have any input on that feel free to let me know)
   - Some method reordering and readability changes will come for sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org