You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/30 07:22:15 UTC

[GitHub] [dubbo-go] cvictory opened a new pull request #1028: Fix: support getty send Length, when the data transfer failed 

cvictory opened a new pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028


   When the data is transfer failed and only transfered part of data, then the server can't decode the data.  
   
   So we should close the session.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028#issuecomment-770714460


   pls change the target branch to 1.5


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028#issuecomment-771512918


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=h1) Report
   > Merging [#1028](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=desc) (fdd545b) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/968650f658b63c11bb0409897d29c57b91cfaf50?el=desc) (968650f) will **decrease** coverage by `0.02%`.
   > The diff coverage is `51.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1028/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1028      +/-   ##
   ==========================================
   - Coverage   59.53%   59.50%   -0.03%     
   ==========================================
     Files         259      261       +2     
     Lines       12737    12973     +236     
   ==========================================
   + Hits         7583     7720     +137     
   - Misses       4199     4272      +73     
   - Partials      955      981      +26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (-5.56%)` | :arrow_down: |
   | [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
   | [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
   | [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `89.47% <ø> (+12.20%)` | :arrow_up: |
   | [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
   | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `51.72% <ø> (ø)` | |
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <0.00%> (+0.87%)` | :arrow_up: |
   | ... and [150 more](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=footer). Last update [48de79c...fdd545b](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028#issuecomment-771512918


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=h1) Report
   > Merging [#1028](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=desc) (fdd545b) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/968650f658b63c11bb0409897d29c57b91cfaf50?el=desc) (968650f) will **decrease** coverage by `0.02%`.
   > The diff coverage is `51.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1028/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1028      +/-   ##
   ==========================================
   - Coverage   59.53%   59.50%   -0.03%     
   ==========================================
     Files         259      261       +2     
     Lines       12737    12973     +236     
   ==========================================
   + Hits         7583     7720     +137     
   - Misses       4199     4272      +73     
   - Partials      955      981      +26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (-5.56%)` | :arrow_down: |
   | [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
   | [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
   | [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `89.47% <ø> (+12.20%)` | :arrow_up: |
   | [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
   | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `51.72% <ø> (ø)` | |
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <0.00%> (+0.87%)` | :arrow_up: |
   | ... and [150 more](https://codecov.io/gh/apache/dubbo-go/pull/1028/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=footer). Last update [48de79c...fdd545b](https://codecov.io/gh/apache/dubbo-go/pull/1028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cvictory commented on a change in pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028#discussion_r567413276



##########
File path: remoting/getty/getty_client.go
##########
@@ -176,8 +176,14 @@ func (c *Client) Request(request *remoting.Request, timeout time.Duration, respo
 	if session == nil {
 		return errSessionNotExist
 	}
-
-	if err = c.transfer(session, request, timeout); err != nil {
+	var (
+		totalLen int
+		sendLen  int
+	)
+	if totalLen, sendLen, err = c.transfer(session, request, timeout); err != nil {
+		if sendLen != 0 && totalLen != sendLen {
+			go c.Close()

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028#discussion_r567234759



##########
File path: remoting/getty/getty_client.go
##########
@@ -176,8 +176,14 @@ func (c *Client) Request(request *remoting.Request, timeout time.Duration, respo
 	if session == nil {
 		return errSessionNotExist
 	}
-
-	if err = c.transfer(session, request, timeout); err != nil {
+	var (
+		totalLen int
+		sendLen  int
+	)
+	if totalLen, sendLen, err = c.transfer(session, request, timeout); err != nil {
+		if sendLen != 0 && totalLen != sendLen {
+			go c.Close()

Review comment:
       add a log to give a explanation?

##########
File path: remoting/getty/getty_client.go
##########
@@ -176,8 +176,14 @@ func (c *Client) Request(request *remoting.Request, timeout time.Duration, respo
 	if session == nil {
 		return errSessionNotExist
 	}
-
-	if err = c.transfer(session, request, timeout); err != nil {
+	var (
+		totalLen int
+		sendLen  int
+	)
+	if totalLen, sendLen, err = c.transfer(session, request, timeout); err != nil {
+		if sendLen != 0 && totalLen != sendLen {
+			go c.Close()

Review comment:
       add a log to give an explanation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1028: Fix: support getty send Length, when the data transfer failed

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1028:
URL: https://github.com/apache/dubbo-go/pull/1028


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org