You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2023/01/16 10:46:14 UTC
[GitHub] [bookkeeper] gaozhangmin opened a new pull request, #3739: Fix potential direct memory leak of add request
gaozhangmin opened a new pull request, #3739:
URL: https://github.com/apache/bookkeeper/pull/3739
### Motivation
Fixes #3737
### Changes
release the ParsedAddRequest if the connection is disconnected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin closed pull request #3739: Fix potential direct memory leak of add request
Posted by GitBox <gi...@apache.org>.
gaozhangmin closed pull request #3739: Fix potential direct memory leak of add request
URL: https://github.com/apache/bookkeeper/pull/3739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3739: Fix potential direct memory leak of add request
Posted by GitBox <gi...@apache.org>.
horizonzy commented on code in PR #3739:
URL: https://github.com/apache/bookkeeper/pull/3739#discussion_r1071174585
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:
##########
@@ -113,6 +113,10 @@ protected void sendResponse(int rc, Object response, OpStatsLogger statsLogger)
if (response instanceof BookieProtocol.Response) {
((BookieProtocol.Response) response).release();
}
+ if (request instanceof BookieProtocol.ParsedAddRequest) {
Review Comment:
The operation of `request.release` is nothing to do with channel status.
It can't fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3739: Fix potential direct memory leak of add request
Posted by GitBox <gi...@apache.org>.
horizonzy commented on code in PR #3739:
URL: https://github.com/apache/bookkeeper/pull/3739#discussion_r1071174585
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:
##########
@@ -113,6 +113,10 @@ protected void sendResponse(int rc, Object response, OpStatsLogger statsLogger)
if (response instanceof BookieProtocol.Response) {
((BookieProtocol.Response) response).release();
}
+ if (request instanceof BookieProtocol.ParsedAddRequest) {
Review Comment:
The `request.release` is nothing to do with channel status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3739: Fix potential direct memory leak of add request
Posted by GitBox <gi...@apache.org>.
horizonzy commented on code in PR #3739:
URL: https://github.com/apache/bookkeeper/pull/3739#discussion_r1071174585
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:
##########
@@ -113,6 +113,10 @@ protected void sendResponse(int rc, Object response, OpStatsLogger statsLogger)
if (response instanceof BookieProtocol.Response) {
((BookieProtocol.Response) response).release();
}
+ if (request instanceof BookieProtocol.ParsedAddRequest) {
Review Comment:
The operation of `request.release` is nothing to do with channel status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org