[GitHub] [doris] wangbo commented on a diff in pull request #19924: [improvement](pipeline) task group scan entity

["wangbo (via GitHub)" <gi...@apache.org>]

wangbo commented on code in PR #19924:
URL: https://github.com/apache/doris/pull/19924#discussion_r1218047390


##########
be/src/pipeline/task_scheduler.h:
##########
@@ -91,8 +91,7 @@ class TaskScheduler {
 
     void shutdown();
 
-    void update_tg_cpu_share(const taskgroup::TaskGroupInfo& task_group_info,
-                             taskgroup::TaskGroupPtr task_group);
+    TaskQueue* task_queue() const { return _task_queue.get(); }

Review Comment:
   _task_queue is shared by task_scheduler and TaskGroup, so it' better use shared_ptr here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org