You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aromanenko-dev (via GitHub)" <gi...@apache.org> on 2023/02/17 16:12:45 UTC

[GitHub] [beam] aromanenko-dev opened a new pull request, #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

aromanenko-dev opened a new pull request, #25534:
URL: https://github.com/apache/beam/pull/25534

   All Beam modules are migrated to use `sdks/java/extensions/avro`. So it's needed to deprecate Avro API classes in `sdks/java/core` but keep them for a while for a sake of backward compatibility.
   
   Affected classes:
   
   - org.apache.beam.sdk.coders.AvroCoder
   - org.apache.beam.sdk.coders.AvroGenericCoder
   - org.apache.beam.sdk.io.AvroIO
   - org.apache.beam.sdk.io.AvroSource
   - org.apache.beam.sdk.io.DynamicAvroDestinations
   - org.apache.beam.sdk.io.AvroSchemaIOProvider
   - org.apache.beam.sdk.io.AvroSink
   - org.apache.beam.sdk.io.SerializableAvroCodecFactory (package private)
   - org.apache.beam.sdk.io.ConstantAvroDestination (package private)
   - org.apache.beam.sdk.schemas.utils.AvroUtils
   - org.apache.beam.sdk.schemas.utils.AvroByteBuddyUtils (package private)
   - org.apache.beam.sdk.schemas.utils.ConvertHelpers
   - org.apache.beam.sdk.schemas.AvroRecordSchema
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114295906


##########
CHANGES.md:
##########
@@ -88,6 +88,7 @@
 ## Deprecations
 
 * X behavior is deprecated and will be removed in X versions ([#X](https://github.com/apache/beam/issues/X)).
+* Avro classes are deprecated to use in module `beam-sdks-java-core` and will be eventually removed ([#24749](https://github.com/apache/beam/issues/24749)).

Review Comment:
   It would be good to add a short note how to migrate, e.g. mentioning the new module and package name to use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114292414


##########
CHANGES.md:
##########
@@ -88,6 +88,7 @@
 ## Deprecations
 
 * X behavior is deprecated and will be removed in X versions ([#X](https://github.com/apache/beam/issues/X)).
+* Avro classes are deprecated to use in module `beam-sdks-java-core` and will be eventually removed ([#24749](https://github.com/apache/beam/issues/24749)).

Review Comment:
   Nitpick... maybe like below? Though not important
   ```suggestion
   * Avro related classes are deprecated in module `beam-sdks-java-core` and will be eventually removed ([#24749](https://github.com/apache/beam/issues/24749)).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1434864529

   CC: @reuvenlax @kennknowles @lukecwik 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114292414


##########
CHANGES.md:
##########
@@ -88,6 +88,7 @@
 ## Deprecations
 
 * X behavior is deprecated and will be removed in X versions ([#X](https://github.com/apache/beam/issues/X)).
+* Avro classes are deprecated to use in module `beam-sdks-java-core` and will be eventually removed ([#24749](https://github.com/apache/beam/issues/24749)).

Review Comment:
   Nitpick... maybe like below? Though not important
   ```suggestion
    * @deprecated Avro related classes are deprecated in module <code>beam-sdks-java-core</code> and
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114291526


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java:
##########
@@ -107,10 +107,14 @@
  * org.apache.beam.sdk.transforms.GroupByKey} operations.
  *
  * @param <T> the type of elements handled by this coder
+ * @deprecated Avro classes are deprecated to use in module <code>beam-sdks-java-core</code> and

Review Comment:
   Nitpick... maybe like below? Though not important
   ```suggestion
    * @deprecated Avro related classes are deprecated in module <code>beam-sdks-java-core</code> and
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114292414


##########
CHANGES.md:
##########
@@ -88,6 +88,7 @@
 ## Deprecations
 
 * X behavior is deprecated and will be removed in X versions ([#X](https://github.com/apache/beam/issues/X)).
+* Avro classes are deprecated to use in module `beam-sdks-java-core` and will be eventually removed ([#24749](https://github.com/apache/beam/issues/24749)).

Review Comment:
   Nitpick... maybe like below? Though not important
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1440306220

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1440465303

   Failed checks are not related to this change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1434863947

   R: @mosche 
   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114297597


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java:
##########
@@ -107,10 +107,14 @@
  * org.apache.beam.sdk.transforms.GroupByKey} operations.
  *
  * @param <T> the type of elements handled by this coder
+ * @deprecated Avro classes are deprecated to use in module <code>beam-sdks-java-core</code> and

Review Comment:
   Please also mention the new import that should be used instead to make the migration as easy as possible. Same for all below...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1434894833

   CC: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1440317012

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @apilloud for label java.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1440232048

   @mosche Thanks for review, I addressed your comments, ptal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1440246215

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25534:
URL: https://github.com/apache/beam/pull/25534#issuecomment-1435803698

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on code in PR #25534:
URL: https://github.com/apache/beam/pull/25534#discussion_r1114292414


##########
CHANGES.md:
##########
@@ -88,6 +88,7 @@
 ## Deprecations
 
 * X behavior is deprecated and will be removed in X versions ([#X](https://github.com/apache/beam/issues/X)).
+* Avro classes are deprecated to use in module `beam-sdks-java-core` and will be eventually removed ([#24749](https://github.com/apache/beam/issues/24749)).

Review Comment:
   Nitpick... maybe like below? Though not important
   ```suggestion
   * Avro related classes are deprecated in module <code>beam-sdks-java-core</code> and
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev merged pull request #25534: [Avro] Deprecate Avro API classes in "sdks/java/core"

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev merged PR #25534:
URL: https://github.com/apache/beam/pull/25534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org