You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/02 01:52:50 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders.

chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r399857723
 
 

 ##########
 File path: sdks/python/apache_beam/pipeline.py
 ##########
 @@ -1102,6 +1105,10 @@ def transform_to_runner_api(transform,  # type: Optional[ptransform.PTransform]
         (transform_urn in Pipeline.sdk_transforms_with_environment())):
       environment_id = context.default_environment_id()
 
+    def _may_be_preserve_tag(new_tag, pc, input_tags_to_preserve):
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services