[GitHub] [airflow] mik-laj commented on a change in pull request #17448: Aws secrets manager backend

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #17448:
URL: https://github.com/apache/airflow/pull/17448#discussion_r683842856



##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -96,28 +97,74 @@ def __init__(
 
     @cached_property
     def client(self):
-        """Create a Secrets Manager client"""
+        """
+        Create a Secrets Manager client
+        """
         session = boto3.session.Session(
-            profile_name=self.profile_name,
+            profile_name=self.profile_name
         )
         return session.client(service_name="secretsmanager", **self.kwargs)
 
-    def get_conn_uri(self, conn_id: str) -> Optional[str]:
+    def _get_extra(self, secret, conn_string):
+        if 'extra' in secret:
+            extra_dict = secret['extra']
+            kvs = "&".join([f"{key}={value}" for key, value in extra_dict.items()])

Review comment:
       What do you think about [urllib.parse.urlencode(](https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlencode). I'm afraid the current implementation may have problems with some special characters.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org