You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/24 18:28:12 UTC
[GitHub] [druid] Caroline1000 opened a new pull request #11631: DataSchema: improve rollup WARN message
Caroline1000 opened a new pull request #11631:
URL: https://github.com/apache/druid/pull/11631
### Description
When rollup is enabled, the warning message indicates that no metricsSpec is included even if it is included. This PR changes the warning message to only indicate that rollup in enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11631:
URL: https://github.com/apache/druid/pull/11631#issuecomment-908866499
Overruling flaky test in travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11631:
URL: https://github.com/apache/druid/pull/11631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11631:
URL: https://github.com/apache/druid/pull/11631#discussion_r696953249
##########
File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -114,7 +114,7 @@ public DataSchema(
// this validation is not necessarily going to be able to catch everything. It will run again in getDimensionsSpec.
computeAndValidateOutputFieldNames(this.dimensionsSpec, this.aggregators);
- if (this.granularitySpec.isRollup()) {
+ if (this.granularitySpec.isRollup() && && this.aggregators.length == 0) {
Review comment:
```suggestion
if (this.granularitySpec.isRollup() && this.aggregators.length == 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11631:
URL: https://github.com/apache/druid/pull/11631#issuecomment-906014893
`Ease of Use` label because an improvement to log messages make it easier for people to understand what's going on. I couldn't find another relevant label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11631:
URL: https://github.com/apache/druid/pull/11631#issuecomment-908866499
Overruling flaky test in travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11631:
URL: https://github.com/apache/druid/pull/11631#discussion_r696210133
##########
File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -116,8 +116,7 @@ public DataSchema(
if (this.granularitySpec.isRollup()) {
Review comment:
It seems like another option is to only warn if isRollup is true and aggregators is empty. This way the current warning message would make more sense.
```suggestion
if (this.granularitySpec.isRollup() && && this.aggregators.length == 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11631:
URL: https://github.com/apache/druid/pull/11631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11631: DataSchema: improve rollup WARN message
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11631:
URL: https://github.com/apache/druid/pull/11631#discussion_r696210372
##########
File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -116,8 +116,7 @@ public DataSchema(
if (this.granularitySpec.isRollup()) {
log.warn(
- "Rollup is enabled for dataSource [%s] but no metricsSpec has been provided. "
- + "Are you sure this is what you want?",
+ "Rollup is enabled for dataSource [%s]",
Review comment:
```suggestion
"Rollup is enabled for dataSource [%s] but no metricsSpec has been provided. "
+ "Are you sure this is what you want?",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org