You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/07 11:16:40 UTC
[GitHub] lebeg commented on a change in pull request #13681: Making MKL-DNN
default on MXNet master
lebeg commented on a change in pull request #13681: Making MKL-DNN default on MXNet master
URL: https://github.com/apache/incubator-mxnet/pull/13681#discussion_r245622429
##########
File path: CMakeLists.txt
##########
@@ -20,7 +20,7 @@ mxnet_option(USE_F16C "Build with x86 F16C instruction support" ON)
mxnet_option(USE_LAPACK "Build with lapack support" ON)
mxnet_option(USE_MKL_IF_AVAILABLE "Use MKL if found" ON)
mxnet_option(USE_MKLML_MKL "Use MKLDNN variant of MKL (if MKL found)" ON IF USE_MKL_IF_AVAILABLE AND (NOT APPLE))
-mxnet_option(USE_MKLDNN "Use MKLDNN variant of MKL (if MKL found)" ON IF USE_MKL_IF_AVAILABLE AND (NOT APPLE))
+mxnet_option(USE_MKLDNN "Use MKLDNN variant of MKL (if MKL found)" ON IF USE_MKL_IF_AVAILABLE AND (NOT APPLE) AND (NOT MSVC) AND (CMAKE_SYSTEM_PROCESSOR MATCHES x86_64))
Review comment:
Actually `CMAKE_SYSTEM_PROCESSOR` will not work for cross compilation. You could reuse a variable `CMAKE_CROSSCOMPILING` for this as shown [here](https://github.com/apache/incubator-mxnet/pull/13576/files#diff-af3b638bc2a3e6c650974192a53c7291R6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services