You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/04/10 18:54:55 UTC
[kudu-CR](branch-1.9.x) tools: escape brackets when generating XML
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12988
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `table scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Reviewed-on: http://gerrit.cloudera.org:8080/12981
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 4eb74ae233fadf5184632f4b291b0befeb371dd5)
---
M src/kudu/tools/tool_action.cc
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/12988/1
--
To view, visit http://gerrit.cloudera.org:8080/12988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12988
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.9.x) tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12988 )
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `table scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Reviewed-on: http://gerrit.cloudera.org:8080/12981
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 4eb74ae233fadf5184632f4b291b0befeb371dd5)
Reviewed-on: http://gerrit.cloudera.org:8080/12988
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action.cc
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12988
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.9.x) tools: escape brackets when generating XML
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12988 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12988
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:55:53 +0000
Gerrit-HasComments: No