You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/20 02:36:28 UTC

Re: Review Request 23708: Fix line comments end punctuation in stout

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23708/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 12:36 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.


Repository: mesos-git


Description
-------

Review: https://reviews.apache.org/r/23708


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1c51315e04267edba2e1e2c86212aeecd6 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 43b1bde53bc151344087d6b5e750c13a5b8d246d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 88b57979a8bd37c52719b8183aa1f8c5290fcd7c 

Diff: https://reviews.apache.org/r/23708/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 23708: Fix line comments end punctuation in stout

Posted by Adam B <ad...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23708/#review51379
-----------------------------------------------------------

Ship it!


Minor suggestion, but otherwise shippable.


3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/23708/#comment89660>

    Seems silly to have such a long NOLINT line when adding '.' to the end would also remove the warning. Perhaps you can space it out like "ab   :" or something similar, to keep the ascii-art style.
    (It also seems silly to argue about this, so I'll go along with NOLINT if you'd rather.)


- Adam B


On Aug. 19, 2014, 5:36 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23708/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:36 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/23708
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1c51315e04267edba2e1e2c86212aeecd6 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 43b1bde53bc151344087d6b5e750c13a5b8d246d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 88b57979a8bd37c52719b8183aa1f8c5290fcd7c 
> 
> Diff: https://reviews.apache.org/r/23708/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 23708: Fix line comments end punctuation in stout

Posted by Niklas Nielsen <ni...@qni.dk>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23708/#review52820
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Aug. 19, 2014, 5:36 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23708/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:36 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/23708
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1c51315e04267edba2e1e2c86212aeecd6 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 43b1bde53bc151344087d6b5e750c13a5b8d246d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 88b57979a8bd37c52719b8183aa1f8c5290fcd7c 
> 
> Diff: https://reviews.apache.org/r/23708/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>