You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/05 14:38:44 UTC

[GitHub] [beam] lukecwik opened a new pull request, #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

lukecwik opened a new pull request, #22607:
URL: https://github.com/apache/beam/pull/22607

   Linkage checker failures under 1.48.1:
   ```
   Class org.eclipse.jetty.npn.NextProtoNego is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.alpn.ALPN$ClientProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.alpn.ALPN is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.asn1.x500.X500Name is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.cert.jcajce.JcaX509v3CertificateBuilder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.operator.jcajce.JcaContentSignerBuilder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.cert.X509v3CertificateBuilder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.cert.jcajce.JcaX509CertificateConverter is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.jce.provider.BouncyCastleProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.npn.NextProtoNego$ClientProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.npn.NextProtoNego$ServerProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.alpn.ALPN$ServerProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.JZlib$WrapperType is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.JZlib is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.Inflater is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.Deflater is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.aayushatharva.brotli4j.decoder.DecoderJNI$Status is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliDecoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.github.luben.zstd.Zstd is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZstdEncoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.aayushatharva.brotli4j.encoder.Encoder$Parameters is not found;
     referenced by 3 class files
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.StandardCompressionOptions (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliOptions (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliEncoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.aayushatharva.brotli4j.decoder.DecoderJNI$Wrapper is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliDecoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.aayushatharva.brotli4j.encoder.Encoder$Mode is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliOptions (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.JZlibEncoder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.JZlibDecoder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.aayushatharva.brotli4j.encoder.Encoders is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliEncoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.Logger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLogger (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.LoggerFactory is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.helpers.NOPLoggerFactory is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.spi.LocationAwareLogger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.LocationAwareSlf4JLogger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class reactor.blockhound.integration.BlockHoundIntegration is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class reactor.blockhound.BlockHound$Builder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
     Cause:
       Unknown
   ```
   
   Linkage checker failures under 1.43.2:
   ```
   Class org.eclipse.jetty.npn.NextProtoNego$ServerProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.asn1.x500.X500Name is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.cert.jcajce.JcaX509v3CertificateBuilder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.operator.jcajce.JcaContentSignerBuilder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.cert.X509v3CertificateBuilder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.cert.jcajce.JcaX509CertificateConverter is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.bouncycastle.jce.provider.BouncyCastleProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.alpn.ALPN is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.npn.NextProtoNego is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.alpn.ALPN$ClientProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.eclipse.jetty.alpn.ALPN$ServerProvider is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.JZlibEncoder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.JZlibDecoder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.JZlib$WrapperType is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.JZlib is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.Inflater is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class com.jcraft.jzlib.Deflater is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class reactor.blockhound.integration.BlockHoundIntegration is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class reactor.blockhound.BlockHound$Builder is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.Logger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLogger (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.LoggerFactory is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.helpers.NOPLoggerFactory is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.slf4j.spi.LocationAwareLogger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   Class org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.LocationAwareSlf4JLogger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
     Cause:
       Unknown
   ```
   
   The differences are in optional new compression algorithms zstd and brotli and NextProtoNego$ClientProvider which are safe to exclude.
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] emilymye commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
emilymye commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206709964

   LGTM - as a note, if you're also doing a BOM update, we should maybe revisit  https://github.com/apache/beam/pull/16672/ as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206534107

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206701468

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206787140

   > LGTM - as a note, if you're also doing a BOM update, we should maybe revisit #16672 as well
   
   No BOM update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206632751

   Run Java_Examples_Dataflow_Java11 PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206849317

   Last check succeeded but failed to update github ui: https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/5475/console


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik merged pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #22607:
URL: https://github.com/apache/beam/pull/22607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206784877

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206560333

   # [Codecov](https://codecov.io/gh/apache/beam/pull/22607?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22607](https://codecov.io/gh/apache/beam/pull/22607?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1332ee) into [master](https://codecov.io/gh/apache/beam/commit/c8d92b03b6b2029978dbc2bf824240232c5e61ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8d92b0) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #22607      +/-   ##
   ==========================================
   - Coverage   74.23%   74.22%   -0.02%     
   ==========================================
     Files         707      707              
     Lines       93301    93301              
   ==========================================
   - Hits        69261    69250      -11     
   - Misses      22772    22783      +11     
     Partials     1268     1268              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.60% <ø> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/22607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
   | [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.01% <0.00%> (-1.39%)` | :arrow_down: |
   | [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.06% <0.00%> (-1.33%)` | :arrow_down: |
   | [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.71% <0.00%> (-0.31%)` | :arrow_down: |
   | [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `88.94% <0.00%> (-0.16%)` | :arrow_down: |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.54% <0.00%> (-0.13%)` | :arrow_down: |
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #22607: [BEAM-14118, #21639] Vendor gRPC 1.48.1

Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22607:
URL: https://github.com/apache/beam/pull/22607#issuecomment-1206533077

   R: @jigga @apilloud @emilymye 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org