You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/10/17 21:00:21 UTC

[GitHub] ashb commented on a change in pull request #4061: [AIRFLOW-2799] Fix filtering UI objects by datetime

ashb commented on a change in pull request #4061: [AIRFLOW-2799] Fix filtering UI objects by datetime
URL: https://github.com/apache/incubator-airflow/pull/4061#discussion_r226092639
 
 

 ##########
 File path: airflow/www/utils.py
 ##########
 @@ -448,7 +448,42 @@ def __call__(self, field, **kwargs):
         return wtforms.widgets.core.HTMLString(html)
 
 
-class UtcFilterConverter(FilterConverter):
+class BaseUtcDateTimeFilter(object):
 
 Review comment:
   `BaseDateTimeFilter` comes in from `sqlafilters.DateTimeEqualFilter` etc - this is more of a "mix-in" than it's.....
   
   Welll _only_ the `>=` filter works. Thanks for catching

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services