You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/10 06:29:57 UTC

[kudu-CR](branch-1.10.x) [build-support] add info on libyaml-cpp 

Hello Kudu Jenkins, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14680

to review the following change.


Change subject: [build-support] add info on libyaml-cpp
......................................................................

[build-support] add info on libyaml-cpp

Added license information on libyaml-cpp into the
mini-cluster binary license file on linux.

Change-Id: I7ea9371501cfe669b32acf0615bf9b9b29cbff06
Reviewed-on: http://gerrit.cloudera.org:8080/14599
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 973e5cdf8fbcedcdcc659d980f3a3a69dc4f109f)
  modified:   build-support/mini-cluster/LICENSE-BINARY-JAR-LINUX.txt
  modified:   the original commit description
                 removed information on libnuma license
---
M build-support/mini-cluster/LICENSE-BINARY-JAR-LINUX.txt
1 file changed, 25 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/14680/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ea9371501cfe669b32acf0615bf9b9b29cbff06
Gerrit-Change-Number: 14680
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.10.x) [build-support] add info on libyaml-cpp

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14680 )

Change subject: [build-support] add info on libyaml-cpp
......................................................................


Patch Set 1: Verified+1 Code-Review+2

mini-cluster related change


-- 
To view, visit http://gerrit.cloudera.org:8080/14680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea9371501cfe669b32acf0615bf9b9b29cbff06
Gerrit-Change-Number: 14680
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 10 Nov 2019 06:30:55 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.10.x) [build-support] add info on libyaml-cpp

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14680 )

Change subject: [build-support] add info on libyaml-cpp
......................................................................

[build-support] add info on libyaml-cpp

Added license information on libyaml-cpp into the
mini-cluster binary license file on linux.

Change-Id: I7ea9371501cfe669b32acf0615bf9b9b29cbff06
Reviewed-on: http://gerrit.cloudera.org:8080/14599
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 973e5cdf8fbcedcdcc659d980f3a3a69dc4f109f)
  modified:   build-support/mini-cluster/LICENSE-BINARY-JAR-LINUX.txt
  modified:   the original commit description
                 removed information on libnuma license
Reviewed-on: http://gerrit.cloudera.org:8080/14680
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/mini-cluster/LICENSE-BINARY-JAR-LINUX.txt
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ea9371501cfe669b32acf0615bf9b9b29cbff06
Gerrit-Change-Number: 14680
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)