[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4791: Support STRING and BYTES for no dictionary columns in realtime consuming segments

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #4791: Support STRING and BYTES for no dictionary columns in realtime consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4791#discussion_r343378580
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/core/common/RealtimeNoDictionaryTest.java
 ##########
 @@ -38,11 +41,13 @@
   private static final String LONG_COL_NAME = "longcol";
   private static final String FLOAT_COL_NAME = "floatcol";
   private static final String DOUBLE_COL_NAME = "doublecol";
-  private static final int NUM_ROWS = 1000;
+  private static final String STRING_COL_NAME = "stringcol";
+  private static final int NUM_ROWS = 10;
 
 Review comment:
   Sorry this was a bad change... while I was debugging the test I added. Need to undo this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org