[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #831: GEODE-9431: Replaced std regex with Boost due to RHEL8.

[GitBox <gi...@apache.org>]

pdxcodemonkey commented on a change in pull request #831:
URL: https://github.com/apache/geode-native/pull/831#discussion_r672430467



##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -54,11 +54,11 @@ class APACHE_GEODE_EXPORT CacheableString
       : m_str(std::move(value)), m_hashcode(0) {
     bool ascii = isAscii(m_str);
 
-    m_type = m_str.length() > (std::numeric_limits<uint16_t>::max)()
-                 ? ascii ? DSCode::CacheableASCIIStringHuge
-                         : DSCode::CacheableStringHuge
-             : ascii ? DSCode::CacheableASCIIString
-                     : DSCode::CacheableString;
+    m_type =
+        m_str.length() > (std::numeric_limits<uint16_t>::max)()
+            ? ascii ? DSCode::CacheableASCIIStringHuge
+                    : DSCode::CacheableStringHuge
+            : ascii ? DSCode::CacheableASCIIString : DSCode::CacheableString;

Review comment:
       Fixed - just another artifact of the fact that the CI version of clangformat is "special" :/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org