You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2014/11/26 02:29:34 UTC
[jclouds-labs-google] Converting tests to Mock (#102)
A significant start at converting to MockTests.
PATCH requests appear to not be handled correctly (throws errors) so I left those for now.
You can merge this Pull Request by running:
git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google toMock
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/102
-- Commit Summary --
* Converting tests to Mock
-- File Changes --
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AddressApiExpectTest.java (149)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AddressApiMockTest.java (87)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/BackendServiceApiExpectTest.java (146)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/BackendServiceApiMockTest.java (136)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiExpectTest.java (217)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiMockTest.java (128)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskTypeApiExpectTest.java (101)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskTypeApiMockTest.java (63)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiExpectTest.java (90)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiMockTest.java (82)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiExpectTest.java (177)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiMockTest.java (104)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/GlobalForwardingRuleApiExpectTest.java (177)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/GlobalForwardingRuleApiMockTest.java (106)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiExpectTest.java (141)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiMockTest.java (109)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiMockTest.java (12)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiExpectTest.java (321)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiMockTest.java (158)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/MachineTypeApiExpectTest.java (109)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/MachineTypeApiMockTest.java (63)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseBackendServiceGetHealthTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseBackendServiceListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseBackendServiceTest.java (12)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskListTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallTest.java (9)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseForwardingRuleListTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseForwardingRuleTest.java (10)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationTest.java (9)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceTest.java (17)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionOperationTest.java (11)
M google-compute-engine/src/test/resources/address_get.json (1)
D google-compute-engine/src/test/resources/machinetype_list_central1b.json (41)
D google-compute-engine/src/test/resources/machinetype_list_central1b_empty.json (6)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/102.patch
https://github.com/jclouds/jclouds-labs-google/pull/102.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/102
Re: [jclouds-labs-google] Converting tests to Mock (#102)
Posted by Adrian Cole <no...@github.com>.
Closed #102.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/102#event-199273599
Re: [jclouds-labs-google] Converting tests to Mock (#102)
Posted by Ignasi Barrera <no...@github.com>.
> PATCH requests appear to not be handled correctly (throws errors) so I left those for now
The PATCH verb is not well supported in the default Java HttpUrlConnection. Could you try using the [OkHttp driver](https://github.com/jclouds/jclouds/tree/master/drivers/okhttp)? You can add it when creating the context, or if it turns that using PATCH methods is mandatory for GCE, then you can declare it in the ApiMetadata default module list, making it the default http driver for this provider.
Anyway, this is just a hint to be addressed in a different PR :) I just wanted to leave the note.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/102#issuecomment-64529996
Re: [jclouds-labs-google] Converting tests to Mock (#102)
Posted by Adrian Cole <no...@github.com>.
A significant thanks! merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/102#issuecomment-64725710
Re: [jclouds-labs-google] Converting tests to Mock (#102)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #318](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/318/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/102#issuecomment-64501881
Re: [jclouds-labs-google] Converting tests to Mock (#102)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #1789](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1789/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/102#issuecomment-64502229