You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2016/10/13 13:53:59 UTC
[GitHub] nifi pull request #1130: NIFI-2819: Added support for Expresssion Language i...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1130
NIFI-2819: Added support for Expresssion Language in ModifyBytes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2819
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1130
----
commit 0c4b9e56e1729723039339ceee4dc78e0cd74862
Author: Matt Burgess <ma...@apache.org>
Date: 2016-10-13T13:50:56Z
NIFI-2819: Added support for Expresssion Language in ModifyBytes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1130: NIFI-2819: Added support for Expression Language in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1130: NIFI-2819: Added support for Expression Language in...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1130#discussion_r83460093
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ModifyBytes.java ---
@@ -66,13 +66,15 @@
.required(true)
.addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
.defaultValue("0 B")
+ .expressionLanguageSupported(true)
.build();
public static final PropertyDescriptor END_OFFSET = new PropertyDescriptor.Builder()
.name("End Offset")
--- End diff --
When I saw _end-offset_ i got confused since the next offset is the end offset, but description states its _Number of bytes removed at the end of the file_. This means it's not an offset at all.
I know this is not part of the immediate issue, but at least consider raising an improvement JIRA where this could be fixed. Obviously we can't change the _name_, so we'll keep it, but we can add _displayProperty(..)_
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1130: NIFI-2819: Added support for Expression Language in...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1130#discussion_r86191393
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ModifyBytes.java ---
@@ -66,13 +66,15 @@
.required(true)
.addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
.defaultValue("0 B")
+ .expressionLanguageSupported(true)
.build();
public static final PropertyDescriptor END_OFFSET = new PropertyDescriptor.Builder()
.name("End Offset")
--- End diff --
@mattyb149 yes it's +1 here. And yes please raise the improvement JIRA.
I'll merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---