You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/10 01:04:54 UTC
[GitHub] andrewfayres commented on a change in pull request #13823:
[MXNET-1177]Adding Scala Demo to be run as a part of Nightly CI
andrewfayres commented on a change in pull request #13823: [MXNET-1177]Adding Scala Demo to be run as a part of Nightly CI
URL: https://github.com/apache/incubator-mxnet/pull/13823#discussion_r246606317
##########
File path: scala-package/mxnet-demo/scala-demo/Makefile
##########
@@ -44,11 +43,14 @@ endif
scalademo:
(mvn package -Dmxnet.profile=$(SCALA_PKG_PROFILE) \
-Dmxnet.scalaprofile=$(SCALA_VERSION_PROFILE) \
- -Dmxnet.version=$(MXNET_VERSION) \
+ -Dscala.version=$(SCALA_VERSION))
+
+scalacidemo:
Review comment:
Two comments:
1.) (Nitpick) I'm not crazy about this name, mainly because scalac is the compiler and this is easily read as "scalac i demo".
2.) This is being done a bit differently than how the java-demo one is done. First, the Java one only has javademo and javaclean. The nightly uses make javademo instead of introducing a javacidemo. Also, the javademo makefile uses mvn install instead of mvn package. Are you aware of anything that keeps the two from being consistent with each other?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services