You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2015/04/01 12:12:00 UTC
spark git commit: [SPARK-6597][Minor] Replace `input:checkbox` with
`input[type="checkbox"]` in additional-metrics.js
Repository: spark
Updated Branches:
refs/heads/master 412262346 -> d824c11c9
[SPARK-6597][Minor] Replace `input:checkbox` with `input[type="checkbox"]` in additional-metrics.js
In additional-metrics.js, there are some selector notation like `input:checkbox` but JQuery's official document says `input[type="checkbox"]` is better.
https://api.jquery.com/checkbox-selector/
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Closes #5254 from sarutak/SPARK-6597 and squashes the following commits:
a253bc4 [Kousuke Saruta] Replaced input:checkbox with input[type="checkbox"]
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/d824c11c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/d824c11c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/d824c11c
Branch: refs/heads/master
Commit: d824c11c9fe8af1ca1d7c694b2fb81289eb83f97
Parents: 4122623
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Authored: Wed Apr 1 11:11:56 2015 +0100
Committer: Sean Owen <so...@cloudera.com>
Committed: Wed Apr 1 11:11:56 2015 +0100
----------------------------------------------------------------------
.../org/apache/spark/ui/static/additional-metrics.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/d824c11c/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js b/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
index 14ba37d..013db8d 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
@@ -30,7 +30,7 @@ $(function() {
stripeSummaryTable();
- $("input:checkbox").click(function() {
+ $('input[type="checkbox"]').click(function() {
var column = "table ." + $(this).attr("name");
$(column).toggle();
stripeSummaryTable();
@@ -39,15 +39,15 @@ $(function() {
$("#select-all-metrics").click(function() {
if (this.checked) {
// Toggle all un-checked options.
- $('input:checkbox:not(:checked)').trigger('click');
+ $('input[type="checkbox"]:not(:checked)').trigger('click');
} else {
// Toggle all checked options.
- $('input:checkbox:checked').trigger('click');
+ $('input[type="checkbox"]:checked').trigger('click');
}
});
// Trigger a click on the checkbox if a user clicks the label next to it.
$("span.additional-metric-title").click(function() {
- $(this).parent().find('input:checkbox').trigger('click');
+ $(this).parent().find('input[type="checkbox"]').trigger('click');
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org