You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2020/07/30 09:52:00 UTC

[jira] [Resolved] (HBASE-24797) Move log code out of loop

     [ https://issues.apache.org/jira/browse/HBASE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viraj Jasani resolved HBASE-24797.
----------------------------------
    Fix Version/s: 2.4.0
                   2.3.1
     Hadoop Flags: Reviewed
       Resolution: Fixed

> Move log code out of loop
> -------------------------
>
>                 Key: HBASE-24797
>                 URL: https://issues.apache.org/jira/browse/HBASE-24797
>             Project: HBase
>          Issue Type: Bug
>          Components: Normalizer
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Sun Xin
>            Assignee: Sun Xin
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> In HMaster#normalizeRegions, maybe we shoule move the log code about  submittedPlanProcIds out of loop.
>  
> {code:java}
> public boolean normalizeRegions() throws IOException {
>   ...
>     final List<Long> submittedPlanProcIds = new ArrayList<>();
>     for (TableName table : allEnabledTables) {
>       ...
>       for (NormalizationPlan plan : plans) {
>         long procId = plan.submit(this);
>         submittedPlanProcIds.add(procId);
>         ...
>       }
>       int totalPlansSubmitted = submittedPlanProcIds.size();
>       if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
>         LOG.debug("Normalizer plans submitted. Total plans count: {} , procID list: {}",
>           totalPlansSubmitted, submittedPlanProcIds);
>       }
>     }
>   ...
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)