You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/02/22 16:13:28 UTC

DO NOT REPLY [Bug 48795] New: Tomcat tries to use cache when compilation failed

https://issues.apache.org/bugzilla/show_bug.cgi?id=48795

           Summary: Tomcat tries to use cache when compilation failed
           Product: Tomcat 6
           Version: 6.0.24
          Platform: PC
        OS/Version: Windows Vista
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: apache@scribeofthenile.com


Created an attachment (id=25037)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25037)
Full error log.

After compilation of a JSP fails, Tomcat will often still try to use the
(non-existant) cached version.

For example, I have a simple JSP containing only "Hello, <%=name%>".
When accessing for the first time, Tomcat throws
"org.apache.jasper.JasperException: Unable to compile class for JSP".

Subsequent requests will alternate between this error, and
"java.lang.ClassNotFoundException: org.apache.jsp.jsp.test_jsp".

In the case of editing existing JSPs which have compiled fine, the response
will alternate between the original error, and the cache of the last-good JSP.

I'm using Sun JVM 1.6.0_18-b07.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48795] Tomcat tries to use cache when compilation failed

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48795

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Mark Thomas <ma...@apache.org> 2010-05-18 14:49:02 EDT ---
This has been fixed in 6.0.x and will be included in 6.0.26 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48795] Tomcat tries to use cache when compilation failed

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48795

--- Comment #3 from apache@scribeofthenile.com 2010-03-12 14:22:46 UTC ---
Thanks for following up on this issue.

Does the proposed patch also address the case when a JSP has compiled and
cached successfully and is subsequently edited with some syntax error? In this
situation Tomcat seems to not invalidate the cache.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48795] Tomcat tries to use cache when compilation failed

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48795

--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-03-11 20:39:50 UTC ---
After some discussion, a modified patch has been applied and proposed.

The issue is that immediately re-trying the compilation increases the risk of a
DOS attack. Whilst JSP compilation failures shouldn't happen in production,
they often do.

The new approach adds a new init parameter for the JSP servlet that controls if
failed compilations are immediately retried on the next access or if
modificationTestInterval is honour. This only applies in development mode.

For versions where this feature is not available, consider setting
modificationTestInterval to 0. Again the same warning re DOS applies.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48795] Tomcat tries to use cache when compilation failed

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48795

--- Comment #1 from Mark Thomas <ma...@apache.org> 2010-03-10 17:37:48 UTC ---
This has been fixed in trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org