[jira] [Resolved] (THRIFT-2205) Node.js Test Server to support test.js JavaScript Browser test and sundry fixes

["Jens Geyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-2205.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.2

I just committed this - many thanks to Randy and Pierre! What a monster of a patch.

{quote}
In MultiplexedProcessor is there any reason to use a Map Object instead of a bare JS Object ? Using Map requires node to run with the harmony flags, this can be easily avoided to my mind.
{quote}

I have another minor thing that should be changed: There are two very long lines in test.js and test_driver.js, containing languages native names and adding up to more than 1500 chars. How about adding a few linebreaks?



> Node.js Test Server to support test.js JavaScript Browser test and sundry fixes
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-2205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2205
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library, Node.js - Library
>    Affects Versions: 1.0
>         Environment: All
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
>              Labels: node, nodejs
>             Fix For: 0.9.2
>
>         Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch, 0002-node-Bin-Frame-client-server-test-update.patch, 0003-node-throwed-error-should-be-instanciated.patch, 0004-node-fix-TJSONProtocol-parser.patch, 0005-node-tests-for-json-frame-and-bin-buf.patch, 0006-node-fix-multiplexed-processor-for-buffered-transpor.patch
>
>
> Adds lib/nodejs/test/testsvr.js 
> This server depends on ThriftTest[.js] and runs clean with test.js in the browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes overflow on Javascript I64 tests. Improves static_server header output.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)