You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/03 16:10:24 UTC

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues

arpadboda commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r374135283
 
 

 ##########
 File path: libminifi/include/io/ClientSocket.h
 ##########
 @@ -93,7 +109,7 @@ class Socket : public BaseStream {
    */
   virtual int16_t initialize();
 
-  virtual void setInterface(io::NetworkInterface &&interface) {
+  virtual void setInterface(io::NetworkInterface interface) noexcept {
 
 Review comment:
   Is there any reason of writing noexcepts here?
   
   In case of the big 4 (move/cpy assignment/construction) it's reasonable as stl containers require that, but otherwise I see no value added. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services